Declare a "server cluster interface" that is intended to combine "attribute access interface" and "command handler interface" #37541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
github-actions
bot
added
scripts
lib
app
core
documentation
andy31415
force-pushed
the
server-cluster-interface
branch
from
c7ccbb3 to
4eab278
Compare
|
PR #37541: Size comparison from 522876c to 4eab278 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 522876c to 8f7a492 Full report (3 builds for cc32xx, stm32)
|
|
PR #37541: Size comparison from 522876c to 576c374 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 522876c to a854a2c Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
mspang
reviewed
Feb 13, 2025
|
PR #37541: Size comparison from 522876c to 2f39744 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
mspang
reviewed
Feb 13, 2025
|
PR #37541: Size comparison from 522876c to 57f2321 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 08535fd to 0785397 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #37541: Size comparison from 08535fd to b2b80a1 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 5621ff6 to c65e9a3 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #37541: Size comparison from 5621ff6 to 33aaf5c Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 00c6f4e to 265ed70 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 64ae4d8 to b7f8e79 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 64ae4d8 to 75c7879 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #37541: Size comparison from 64ae4d8 to 28a21f7 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 73fe30c to 149a91b Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 73fe30c to bd5a80b Increases above 0.2%:
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from 73fe30c to b148b82 Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37541: Size comparison from ab3d5ae to 091b2c1 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Feb 28, 2025
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.cpp
Outdated
Show resolved
Hide resolved
|
PR #37541: Size comparison from ab3d5ae to b495b5b Full report (3 builds for cc32xx, stm32)
|
andy31415
force-pushed
the
server-cluster-interface
branch
from
25a2112 to
f36dfde
Compare
andy31415
force-pushed
the
server-cluster-interface
branch
from
f36dfde to
f301851
Compare
tcarmelveilleux
approved these changes
Mar 3, 2025
|
PR #37541: Size comparison from 4e3f1cd to f301851 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines a
ServerClusterInterfaceclass along with a registry. Also slight update tobuild_coverageto run on more (specifically my) machines without errors.Implementation notes:
InvoketoInvokeCommandas per review feedback. Made this new name consistent across the new interface andDataModel::ProviderThis is currently unused. I expect usages to add flash & RAM cost, that will be slowly offset (especially RAM) as we move clusters around:
TLDR on resourcing: probably ok on RAM over time, there is a flash overhead for this, claiming this is important for testable and maintainable code in the future.
Testing
Unit tests created. Got 100% coverage (including testing trivial "return error" functions to get that). The registry includes a randomized stress test.