[third-party] Add third_party/libdatachannel #37572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #37572: Size comparison from 96bf5df to 3babe3a Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/thirdpart/libdatachannel
branch
from
3babe3a to
e87ad3b
Compare
|
PR #37572: Size comparison from 9d99ef2 to e87ad3b Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, nrfconnect, nxp, psoc6, qpg, stm32)
|
yufengwangca
force-pushed
the
pr/thirdpart/libdatachannel
branch
from
e87ad3b to
fc77331
Compare
yufengwangca
changed the title
yufengwangca
added
the
changing-submodules-on-purpose
|
PR #37572: Size comparison from 94a47ad to fc77331 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37572: Size comparison from 94a47ad to a45da1e Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/thirdpart/libdatachannel
branch
from
a45da1e to
8521f81
Compare
|
PR #37572: Size comparison from 1b3f616 to 8521f81 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
force-pushed
the
pr/thirdpart/libdatachannel
branch
from
8521f81 to
856e73f
Compare
yufengwangca
force-pushed
the
pr/thirdpart/libdatachannel
branch
from
856e73f to
9e80551
Compare
|
PR #37572: Size comparison from 1b3f616 to 9e80551 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Feb 14, 2025
andy31415
approved these changes
Feb 14, 2025
|
PR #37572: Size comparison from 1b3f616 to b2c1341 Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37572: Size comparison from 1b3f616 to 091c259 Full report (28 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
|
PR #37572: Size comparison from 1b3f616 to 37aa94b Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37572: Size comparison from 1b3f616 to 7bbc74a Full report (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #37572: Size comparison from 1b3f616 to 1d30261 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37572: Size comparison from 1b3f616 to 21bbc1c Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
joonhaengHeo
approved these changes
Feb 15, 2025
pidarped
approved these changes
Feb 15, 2025
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
* [Third Party] Add libdatachannel * Fix clang tidy validation error * filter out any that contain third_party * Add a files-ignore pattern when calling tj-actions/changed-files * remove extra spaces * Update filter * Use the changed_files output which respects the files-ignore filter
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
* [Third Party] Add libdatachannel * Fix clang tidy validation error * filter out any that contain third_party * Add a files-ignore pattern when calling tj-actions/changed-files * remove extra spaces * Update filter * Use the changed_files output which respects the files-ignore filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview
We plan to use libdatachannel as the WebRTC lib for camera feature, add third_party/libdatachannel, passed the legal review.
Testing
The camera example app is still in progress, tested with chip-tool by adding libdatachannel as the public dependency