If optional parts of the state we receive over XPC are invalid, just ignore them. #37592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignore them. This avoids failing the things that really matter because something else got confused somehow. Also fixes incorrect handling of the DeviceCachePrimed state.
|
Review changes with |
|
PR #37592: Size comparison from c075fcc to d7f12d3 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
approved these changes
Feb 14, 2025
jtung-apple
reviewed
Feb 14, 2025
Co-authored-by: Jeff Tung <100387939+jtung-apple@users.noreply.github.com>
|
PR #37592: Size comparison from c075fcc to 896920d Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
…ignore them. (project-chip#37592) * If optional parts of the state we receive over XPC are invalid, just ignore them. This avoids failing the things that really matter because something else got confused somehow. Also fixes incorrect handling of the DeviceCachePrimed state. * Fix incorrect variable use. Co-authored-by: Jeff Tung <100387939+jtung-apple@users.noreply.github.com> --------- Co-authored-by: Jeff Tung <100387939+jtung-apple@users.noreply.github.com>
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…ignore them. (project-chip#37592) * If optional parts of the state we receive over XPC are invalid, just ignore them. This avoids failing the things that really matter because something else got confused somehow. Also fixes incorrect handling of the DeviceCachePrimed state. * Fix incorrect variable use. Co-authored-by: Jeff Tung <100387939+jtung-apple@users.noreply.github.com> --------- Co-authored-by: Jeff Tung <100387939+jtung-apple@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids failing the things that really matter because something else got confused somehow.
Also fixes incorrect handling of the DeviceCachePrimed state.
Testing
Manual testing against devices.