Pass the arg of GetPrimaryOrFallbackMACAddress by reference. #37609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementations want to resize it to the size of the data they actually put in it.
|
Review changes with |
|
PR #37609: Size comparison from 7c1d6f7 to 0f05535 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Feb 15, 2025
|
PR #37609: Size comparison from 7c1d6f7 to b96ad62 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
force-pushed
the
mutable-outparam
branch
from
b96ad62 to
cff6dc4
Compare
|
PR #37609: Size comparison from 7c1d6f7 to cff6dc4 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
Damian-Nordic
approved these changes
Feb 18, 2025
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
…-chip#37609) * Pass the arg of GetPrimaryOrFallbackMACAddress by reference. Implementations want to resize it to the size of the data they actually put in it. * Fix TestConfigurationMgr to have correct expectations.
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…-chip#37609) * Pass the arg of GetPrimaryOrFallbackMACAddress by reference. Implementations want to resize it to the size of the data they actually put in it. * Fix TestConfigurationMgr to have correct expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations want to resize it to the size of the data they actually put in it.
Testing
We have existing unit tests for this, but in practice the sizes on caller and callee are identical in our CI configurations, so hard to exercise this codepath.