Rename CLUSTER_MASK_ and ATTIBUTE_MASK defines to differentiate with … #37618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the zigbee ones. Cleanup some scene defines and delete the now empty head att-storage.h
|
Review changes with |
|
PR #37618: Size comparison from 7c1d6f7 to 3ad36b2 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Feb 17, 2025
|
PR #37618: Size comparison from 7c1d6f7 to 4d01666 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
approved these changes
Feb 17, 2025
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
project-chip#37618) * Rename CLUSTER_MASK_ and ATTIBUTE_MASK defines to differentiate with the zigbee ones. Cleanup some scene defines and delete the now empty head att-storage.h * Address comment, replace _BITMAP_ by _FLAG_
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
project-chip#37618) * Rename CLUSTER_MASK_ and ATTIBUTE_MASK defines to differentiate with the zigbee ones. Cleanup some scene defines and delete the now empty head att-storage.h * Address comment, replace _BITMAP_ by _FLAG_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the Zigbee ones.
Clean up some scene defines and delete the now empty header att-storage.h.
CLUSTER_MASK_...->MATTER_CLUSTER_FLAG_...ATTRIBUTE_MASK_...->MATTER_ATTRIBUTE_FLAG_...Those defines are tightly coupled with the
ZAP_CLUSTER_MASKandZAP_ATTRIBUTE_MASKmacros. Those public APIs are not easily modifiable to use more adequate bitflags. It would require some rework and zap changes.Delete unused defines
MATTER_DM_SCENE_TABLE_NULL_INDEX,MATTER_DM_SCENE_TABLE_UNUSED_ENDPOINT_IDandZCL_SCENES_CLUSTER_MAXIMUM_NAME_LENGTHmove
ZCL_SCENES_GLOBAL_SCENE_GROUP_IDandZCL_SCENES_GLOBAL_SCENE_SCENE_IDto be const members of theScenesServerclassTesting
No behaviour change. Only a rename and/or move of defines or constants location.
Locally built for Silabs platform.
CI to validate other builds