Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chime device type to zap-templates/zcl/data-model/chip/matter-devices.xml #37659

Closed
wants to merge 5 commits into from
Closed

Add Chime device type to zap-templates/zcl/data-model/chip/matter-devices.xml #37659

wants to merge 5 commits into from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Feb 19, 2025 •
edited
Loading

Add Chime device type to zap-templates/zcl/data-model/chip/matter-devices.xml

Testing

./scripts/tools/zap/run_zaptool.sh examples/chef/devices/template.zap

Check that Chime is in the list:
Capture d’écran du 2025-02-19 16-58-48

@lboue
Update matter-devices.xml
Loading
Loading status checks…
ee9bced 
Add Chime device type for ZAPtool.
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 19, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/app/zap-templates/zcl/data-model/chip/matter-devices.xml  0% smaller
  src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRDeviceTypeMetadata.mm Unsupported file format
  zzz_generated/chip-tool/zap-generated/cluster/logging/EntryToText.cpp Unsupported file format

@github-actions github-actions bot added the app label Feb 19, 2025
@lboue lboue changed the title Update matter-devices.xml Add Chime device type to zap-templates/zcl/data-model/chip/matter-devices.xml Feb 19, 2025
@lboue lboue marked this pull request as ready for review February 19, 2025 16:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

PR #37659: Size comparison from 86e0b85 to ee9bced

Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
platform target config section 86e0b85 ee9bced change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815244 815244 0 0.0
RAM 120256 120256 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824156 824156 0 0.0
RAM 125352 125352 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771024 771024 0 0.0
RAM 113724 113724 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755300 755300 0 0.0
RAM 113932 113932 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538730 538730 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572886 572886 0 0.0
RAM 205360 205360 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907328 907328 0 0.0
RAM 142315 142315 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901660 901660 0 0.0
RAM 124663 124663 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845948 845948 0 0.0
RAM 141243 141243 0 0.0
qpg lighting-app qpg6105+debug FLASH 662132 662132 0 0.0
RAM 105116 105116 0 0.0
lock-app qpg6105+debug FLASH 620240 620240 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459776 459776 0 0.0
RAM 141472 141472 0 0.0
tizen all-clusters-app arm unknown 5076 5076 0 0.0
FLASH 1750404 1750404 0 0.0
RAM 93260 93260 0 0.0
chip-tool-ubsan arm unknown 11476 11476 0 0.0
FLASH 18960222 18960222 0 0.0
RAM 8296776 8296776 0 0.0

@lboue lboue marked this pull request as draft February 19, 2025 16:16
lboue added 2 commits February 20, 2025 14:00
@lboue
Fix identify cluster
Loading
Loading status checks…
fe16ba0
@lboue
Missing include
Loading
Loading status checks…
d9b947c
@github-actions GitHub Actions
Copy link

PR #37659: Size comparison from 86e0b85 to d9b947c

Full report (3 builds for cc32xx, stm32)
platform target config section 86e0b85 d9b947c change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538730 538746 16 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572886 572902 16 0.0
RAM 205360 205360 0 0.0
stm32 light STM32WB5MM-DK FLASH 459776 459792 16 0.0
RAM 141472 141472 0 0.0

@lboue
Update zap-generated files
Loading
Loading status checks…
f5f3e28
@github-actions GitHub Actions
Copy link

PR #37659: Size comparison from 86e0b85 to f5f3e28

Full report (3 builds for cc32xx, stm32)
platform target config section 86e0b85 f5f3e28 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538730 538802 72 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572886 572950 64 0.0
RAM 205360 205360 0 0.0
stm32 light STM32WB5MM-DK FLASH 459776 459784 8 0.0
RAM 141472 141472 0 0.0

@bzbarsky-apple
Copy link
Contributor

It's a copy/paste mistake from MA-thermostatcontroller above. Fixed.

@lboue are you hand-writing this XML instead of generating it with https://github.com/project-chip/alchemy ?

@lboue
Copy link
Contributor Author

lboue commented Feb 23, 2025

@lboue are you hand-writing this XML instead of generating it with https://github.com/project-chip/alchemy ?

Yes, there is no warning in this file to indicate that it has been autogenerated.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

PR #37659: Size comparison from d618ccb to 4525f97

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section d618ccb 4525f97 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096266 1096266 0 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651586 651586 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 828858 828858 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1060912 1060912 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892098 892098 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 974994 974994 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815268 815268 0 0.0
RAM 120256 120256 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824188 824188 0 0.0
RAM 125352 125352 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771048 771048 0 0.0
RAM 113724 113724 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755332 755332 0 0.0
RAM 113932 113932 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538810 538810 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572966 572966 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656397 656397 0 0.0
RAM 75324 75324 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676257 676257 0 0.0
RAM 77964 77964 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676257 676257 0 0.0
RAM 77964 77964 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633181 633181 0 0.0
RAM 70392 70392 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616261 616261 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635897 635897 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635897 635897 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635757 635757 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655481 655481 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655481 655481 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612105 612105 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631965 631965 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631965 631965 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 939152 939152 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 732240 732240 0 0.0
RAM 234836 234836 0 0.0
window-app BRD4187C FLASH 1031968 1031968 0 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1581984 1581984 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116108 116108 0 0.0
FLASH 1549974 1549974 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2649787 2649787 0 0.0
RAM 111088 111088 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 5921260 5921260 0 0.0
RAM 513712 513712 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5266294 5266294 0 0.0
RAM 221112 221112 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4624936 4624936 0 0.0
RAM 199816 199816 0 0.0
camera-app debug unknown 5424 5424 0 0.0
FLASH 4671716 4671716 0 0.0
RAM 194592 194592 0 0.0
chip-tool debug unknown 6096 6096 0 0.0
FLASH 13302251 13302263 12 0.0
RAM 603392 603392 0 0.0
chip-tool-ipv6only arm64 unknown 21976 21976 0 0.0
FLASH 11323056 11323088 32 0.0
RAM 655192 655192 0 0.0
fabric-admin debug unknown 5784 5784 0 0.0
FLASH 11565205 11565205 0 0.0
RAM 603176 603176 0 0.0
fabric-bridge-app debug unknown 4688 4688 0 0.0
FLASH 4450260 4450260 0 0.0
RAM 187016 187016 0 0.0
fabric-sync debug unknown 4944 4944 0 0.0
FLASH 5569109 5569109 0 0.0
RAM 470400 470400 0 0.0
lighting-app debug+rpc+ui unknown 6152 6152 0 0.0
FLASH 5514385 5514385 0 0.0
RAM 203952 203952 0 0.0
lock-app debug unknown 5392 5392 0 0.0
FLASH 4688404 4688404 0 0.0
RAM 191144 191144 0 0.0
ota-provider-app debug unknown 4728 4728 0 0.0
FLASH 4310584 4310584 0 0.0
RAM 179832 179832 0 0.0
ota-requestor-app debug unknown 4680 4680 0 0.0
FLASH 4440710 4440710 0 0.0
RAM 184320 184320 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2949084 2949084 0 0.0
RAM 143672 143672 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4042312 4042312 0 0.0
RAM 228096 228096 0 0.0
tv-app debug unknown 5720 5720 0 0.0
FLASH 5908021 5908021 0 0.0
RAM 593832 593832 0 0.0
tv-casting-app debug unknown 5296 5296 0 0.0
FLASH 11472733 11472733 0 0.0
RAM 718656 718656 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907676 907676 0 0.0
RAM 142323 142323 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901752 901752 0 0.0
RAM 124663 124663 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846280 846280 0 0.0
RAM 141251 141251 0 0.0
nxp contact k32w0+release FLASH 585232 585232 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600680 600680 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611172 611172 0 0.0
RAM 70164 70164 0 0.0
k32w1+release FLASH 685648 685648 0 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 749504 749504 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646172 1646172 0 0.0
RAM 211472 211472 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552940 1552940 0 0.0
RAM 208288 208288 0 0.0
light cy8ckit_062s2_43012 FLASH 1438612 1438612 0 0.0
RAM 197040 197040 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467500 1467500 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662156 662156 0 0.0
RAM 105116 105116 0 0.0
lock-app qpg6105+debug FLASH 620272 620272 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459800 459800 0 0.0
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 665014 665014 0 0.0
RAM 90728 90728 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622058 622058 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745198 745198 0 0.0
RAM 40396 40396 0 0.0
tl7218x FLASH 753760 753760 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680830 680830 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709392 709392 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600572 600572 0 0.0
RAM 138812 138812 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788714 788714 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5076 5076 0 0.0
FLASH 1750772 1750772 0 0.0
RAM 93260 93260 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18983614 18983622 8 0.0
RAM 8306240 8306240 0 0.0

@lboue
Copy link
Contributor Author

lboue commented Feb 25, 2025

I'll wait for the implementation with Alchemy.

@lboue lboue closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple

Assignees
No one assigned
Labels
app darwin review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lboue @bzbarsky-apple