Rename ArraySize() to MATTER_ARRAY_SIZE() #37660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
soares-sergio
force-pushed
the
fix_array_size
branch
from
a93169e to
f933cc4
Compare
|
PR #37660: Size comparison from 38cc24b to 8204eee Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #37660: Size comparison from 38cc24b to b6c7be2 Full report (28 builds for cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, tizen)
|
soares-sergio
force-pushed
the
fix_array_size
branch
from
b6c7be2 to
ad4e7ed
Compare
|
PR #37660: Size comparison from 0551d0a to 1187b7f Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, tizen)
|
|
PR #37660: Size comparison from 40979b4 to 27b8cf9 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #37660: Size comparison from 72bd391 to a20d0ac Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37660: Size comparison from 72bd391 to 8b5b7f5 Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Feb 20, 2025
rcasallas-silabs
approved these changes
Feb 20, 2025
|
PR #37660: Size comparison from 72bd391 to 4ee8dea Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Feb 20, 2025
|
PR #37660: Size comparison from 0d6b2fb to 9ee7718 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Bypassing CLANG-Tidy here - this is a rename update and it just so happens that we touch a file that has new errors (because we do not check all files on all PRS as that is too slow). I cannot see an obvious reason for its complains. |
popovdg
pushed a commit
to popovdg/connectedhomeip
that referenced
this pull request
Feb 25, 2025
* Rename ArraySize() to MATTER_ARRAY_SIZE * Updated usages of ArraySize() to MATTER_ARRAY_SIZE() * Restyled by clang-format * Guard with #ifndef * fix recently introduced usage in chime * fix typo --------- Co-authored-by: Restyled.io <commits@restyled.io>
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
* Rename ArraySize() to MATTER_ARRAY_SIZE * Updated usages of ArraySize() to MATTER_ARRAY_SIZE() * Restyled by clang-format * Guard with #ifndef * fix recently introduced usage in chime * fix typo --------- Co-authored-by: Restyled.io <commits@restyled.io>
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
* Rename ArraySize() to MATTER_ARRAY_SIZE * Updated usages of ArraySize() to MATTER_ARRAY_SIZE() * Restyled by clang-format * Guard with #ifndef * fix recently introduced usage in chime * fix typo --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames ArraySize() to MATTER_ARRAY_SIZE().
ArraySize() is a macro, so it should be in all caps to not be confused with a function. Also, it is a common name. It can cause symbol clashes very easily.
Testing
Pure renaming. Relying on CI to verify build failures.