Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: diagostics - diagNostics #37689

Merged
merged 7 commits into from
Feb 24, 2025
Merged

Fix typo: diagostics - diagNostics #37689

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d5048bf
Fix typo: diagostics - diagNostics
andreilitvin Feb 20, 2025
90a4a76
Restyled by clang-format
restyled-commits Feb 20, 2025
377d3e0
Merge branch 'master' into typo_fix_diagnostics
andy31415 Feb 20, 2025
5dba455
Fix more typos
andreilitvin Feb 20, 2025
0440ed5
Restyle
andreilitvin Feb 20, 2025
119d06e
Merge branch 'typo_fix_diagnostics' of github.com:andy31415/connected…
andreilitvin Feb 20, 2025
3341acd
Restyled by clang-format
restyled-commits Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

#include <app/util/config.h>

#include "app/server/Server.h"
#include <app-common/zap-generated/attributes/Accessors.h>
#include <app-common/zap-generated/cluster-objects.h>
#include <app-common/zap-generated/ids/Attributes.h>
Expand All @@ -34,6 +33,7 @@
#include <app/CommandHandlerInterfaceRegistry.h>
#include <app/EventLogging.h>
#include <app/reporting/reporting.h>
#include <app/server/Server.h>
#include <app/util/attribute-storage.h>
#include <lib/support/ScopedBuffer.h>
#include <platform/ConnectivityManager.h>
Expand Down Expand Up @@ -112,13 +112,13 @@ TestEventTriggerDelegate * GetTriggerDelegateOnMatchingKey(ByteSpan enableKey)
return triggerDelegate;
}

class GeneralDiagosticsGlobalInstance : public AttributeAccessInterface,
public CommandHandlerInterface,
public DeviceLayer::ConnectivityManagerDelegate
class GeneralDiagnosticsGlobalInstance : public AttributeAccessInterface,
public CommandHandlerInterface,
public DeviceLayer::ConnectivityManagerDelegate
{
public:
// Register for the GeneralDiagnostics cluster on all endpoints.
GeneralDiagosticsGlobalInstance() :
GeneralDiagnosticsGlobalInstance() :
AttributeAccessInterface(Optional<EndpointId>::Missing(), GeneralDiagnostics::Id),
CommandHandlerInterface(Optional<EndpointId>::Missing(), GeneralDiagnostics::Id)
{}
Expand Down Expand Up @@ -151,7 +151,7 @@ class GeneralDiagosticsGlobalInstance : public AttributeAccessInterface,
}
};

CHIP_ERROR GeneralDiagosticsGlobalInstance::Read(const ConcreteReadAttributePath & aPath, AttributeValueEncoder & aEncoder)
CHIP_ERROR GeneralDiagnosticsGlobalInstance::Read(const ConcreteReadAttributePath & aPath, AttributeValueEncoder & aEncoder)
{
if (aPath.mClusterId != GeneralDiagnostics::Id)
{
Expand Down Expand Up @@ -210,7 +210,7 @@ CHIP_ERROR GeneralDiagosticsGlobalInstance::Read(const ConcreteReadAttributePath
return CHIP_NO_ERROR;
}

void GeneralDiagosticsGlobalInstance::InvokeCommand(HandlerContext & handlerContext)
void GeneralDiagnosticsGlobalInstance::InvokeCommand(HandlerContext & handlerContext)
{
switch (handlerContext.mRequestPath.mCommandId)
{
Expand All @@ -234,8 +234,8 @@ void GeneralDiagosticsGlobalInstance::InvokeCommand(HandlerContext & handlerCont
}

template <typename T>
CHIP_ERROR GeneralDiagosticsGlobalInstance::ReadIfSupported(CHIP_ERROR (DiagnosticDataProvider::*getter)(T &),
AttributeValueEncoder & aEncoder)
CHIP_ERROR GeneralDiagnosticsGlobalInstance::ReadIfSupported(CHIP_ERROR (DiagnosticDataProvider::*getter)(T &),
AttributeValueEncoder & aEncoder)
{
T data;
CHIP_ERROR err = (GetDiagnosticDataProvider().*getter)(data);
Expand All @@ -252,8 +252,8 @@ CHIP_ERROR GeneralDiagosticsGlobalInstance::ReadIfSupported(CHIP_ERROR (Diagnost
}

template <typename T>
CHIP_ERROR GeneralDiagosticsGlobalInstance::ReadListIfSupported(CHIP_ERROR (DiagnosticDataProvider::*getter)(T &),
AttributeValueEncoder & aEncoder)
CHIP_ERROR GeneralDiagnosticsGlobalInstance::ReadListIfSupported(CHIP_ERROR (DiagnosticDataProvider::*getter)(T &),
AttributeValueEncoder & aEncoder)
{
CHIP_ERROR err = CHIP_NO_ERROR;
T faultList;
Expand All @@ -277,7 +277,7 @@ CHIP_ERROR GeneralDiagosticsGlobalInstance::ReadListIfSupported(CHIP_ERROR (Diag
return err;
}

CHIP_ERROR GeneralDiagosticsGlobalInstance::ReadNetworkInterfaces(AttributeValueEncoder & aEncoder)
CHIP_ERROR GeneralDiagnosticsGlobalInstance::ReadNetworkInterfaces(AttributeValueEncoder & aEncoder)
{
CHIP_ERROR err = CHIP_NO_ERROR;
DeviceLayer::NetworkInterface * netifs;
Expand All @@ -303,8 +303,8 @@ CHIP_ERROR GeneralDiagosticsGlobalInstance::ReadNetworkInterfaces(AttributeValue
return err;
}

void GeneralDiagosticsGlobalInstance::HandleTestEventTrigger(HandlerContext & ctx,
const Commands::TestEventTrigger::DecodableType & commandData)
void GeneralDiagnosticsGlobalInstance::HandleTestEventTrigger(HandlerContext & ctx,
const Commands::TestEventTrigger::DecodableType & commandData)
{
auto * triggerDelegate = GetTriggerDelegateOnMatchingKey(commandData.enableKey);
if (triggerDelegate == nullptr)
Expand All @@ -320,8 +320,8 @@ void GeneralDiagosticsGlobalInstance::HandleTestEventTrigger(HandlerContext & ct
(handleEventTriggerResult != CHIP_NO_ERROR) ? Status::InvalidCommand : Status::Success);
}

void GeneralDiagosticsGlobalInstance::HandleTimeSnapshot(HandlerContext & ctx,
const Commands::TimeSnapshot::DecodableType & commandData)
void GeneralDiagnosticsGlobalInstance::HandleTimeSnapshot(HandlerContext & ctx,
const Commands::TimeSnapshot::DecodableType & commandData)
{
ChipLogError(Zcl, "Received TimeSnapshot command!");

Expand Down Expand Up @@ -353,8 +353,8 @@ void GeneralDiagosticsGlobalInstance::HandleTimeSnapshot(HandlerContext & ctx,
}

#ifdef GENERAL_DIAGNOSTICS_ENABLE_PAYLOAD_TEST_REQUEST_CMD
void GeneralDiagosticsGlobalInstance::HandlePayloadTestRequest(HandlerContext & ctx,
const Commands::PayloadTestRequest::DecodableType & commandData)
void GeneralDiagnosticsGlobalInstance::HandlePayloadTestRequest(HandlerContext & ctx,
const Commands::PayloadTestRequest::DecodableType & commandData)
{
// Max allowed is 2048.
if (commandData.count > 2048)
Expand Down Expand Up @@ -389,7 +389,7 @@ void GeneralDiagosticsGlobalInstance::HandlePayloadTestRequest(HandlerContext &
}
#endif // GENERAL_DIAGNOSTICS_ENABLE_PAYLOAD_TEST_REQUEST_CMD

GeneralDiagosticsGlobalInstance gGeneralDiagosticsInstance;
GeneralDiagnosticsGlobalInstance gGeneralDiagnosticsInstance;

} // anonymous namespace

Expand Down Expand Up @@ -517,10 +517,10 @@ void MatterGeneralDiagnosticsPluginServerInitCallback()
{
BootReasonEnum bootReason;

AttributeAccessInterfaceRegistry::Instance().Register(&gGeneralDiagosticsInstance);
CommandHandlerInterfaceRegistry::Instance().RegisterCommandHandler(&gGeneralDiagosticsInstance);
AttributeAccessInterfaceRegistry::Instance().Register(&gGeneralDiagnosticsInstance);
CommandHandlerInterfaceRegistry::Instance().RegisterCommandHandler(&gGeneralDiagnosticsInstance);

ConnectivityMgr().SetDelegate(&gGeneralDiagosticsInstance);
ConnectivityMgr().SetDelegate(&gGeneralDiagnosticsInstance);

if (GetDiagnosticDataProvider().GetBootReason(bootReason) == CHIP_NO_ERROR)
{
Expand Down
Loading