-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow objdump to be used for displaying elf sizes #37701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turon
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
saurabhst
approved these changes
Feb 21, 2025
kiel-apple
approved these changes
Feb 21, 2025
PR #37701: Size comparison from 26a7b1c to 2af969f Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Feb 21, 2025
popovdg
pushed a commit
to popovdg/connectedhomeip
that referenced
this pull request
Feb 25, 2025
* Prepare to support objdump for symbols * Ignore offset, have the path computed by the parser * Fix unused variables * Parsing somewhat works ... * Update code a bit, will work on this later * Display works * Display works * Restyle * more redable separators * more support for better filtering --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
ratgr
pushed a commit
to ratgr/connectedhomeip
that referenced
this pull request
Feb 26, 2025
* Prepare to support objdump for symbols * Ignore offset, have the path computed by the parser * Fix unused variables * Parsing somewhat works ... * Update code a bit, will work on this later * Display works * Display works * Restyle * more redable separators * more support for better filtering --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
* Prepare to support objdump for symbols * Ignore offset, have the path computed by the parser * Fix unused variables * Parsing somewhat works ... * Update code a bit, will work on this later * Display works * Display works * Restyle * more redable separators * more support for better filtering --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows filtering by source files. I grabbed the source file path via
strings
(which is terrible, but seems to work).We can now view per section and per path sizes (e.g. we can figure out that zzz_generated uses up 16K of flash)
Testing
Ran locally on a qpg light example: