-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make robotic vacuum cleaner spec compliant #37718
Conversation
… is already set to Stopped resulting in dereferencing a null pointer. Fix this by returning from function if state is stopped
PR #37718: Size comparison from f84fe08 to fd92b12 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
@sxb427 it seems like the tests you ran manually could be automated. Could you do so? |
I just realized this is chef not an official application ... I believe it is fine then, we don't run chef CI (too costly to compile) |
PR #37718: Size comparison from f84fe08 to 154ae8d Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes until we settle down on API exposing (extern variable vs getter function). This should probably be resolved outside PR comments as it seems to need some discussion.
PR #37718: Size comparison from f84fe08 to 80ce709 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
* Start new cycle when RVC Run Mode is changed from idle to cleaning/mapping * Fix bug : Last call to onOperationalStateTimeTick happens after state is already set to Stopped resulting in dereferencing a null pointer. Fix this by returning from function if state is stopped * Change RunMode to Idle after cleaning cycle completes * Restyled by whitespace * Fix tags list for Mapping mode * use getters instead of extern --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Start new cycle when RVC Run Mode is changed from idle to cleaning/mapping * Fix bug : Last call to onOperationalStateTimeTick happens after state is already set to Stopped resulting in dereferencing a null pointer. Fix this by returning from function if state is stopped * Change RunMode to Idle after cleaning cycle completes * Restyled by whitespace * Fix tags list for Mapping mode * use getters instead of extern --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Start new cycle when RVC Run Mode is changed from idle to cleaning/mapping * Fix bug : Last call to onOperationalStateTimeTick happens after state is already set to Stopped resulting in dereferencing a null pointer. Fix this by returning from function if state is stopped * Change RunMode to Idle after cleaning cycle completes * Restyled by whitespace * Fix tags list for Mapping mode * use getters instead of extern --------- Co-authored-by: Restyled.io <commits@restyled.io>
Changes
Testing
Testing using chip tool.
Test for 1 and 2
a. Commission.
b. Read operational state and run mode and ensure both are 0.
c. Set Run Mode to 1 (cleaning)
d. Read operational state and verify it is changed to 1 (running)
e. Set Run Mode to 0 (idle)
f. Read operational state and verify it is changed to 0 (stopped)
Commands after commissioning
Test for 3
a. Commission.
b. Read operational state and run mode and ensure both are 0.
c. Set Run Mode to 1 (cleaning)
d. Read operational state and verify it is changed to 1 (running)
e. Wait for 30 seconds
f. Read operational state and run mode and ensure both are 0.