Adds platform/tests to the ESP32-QEMU unit-test target #37753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37753: Size comparison from 7eab378 to 5873803 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37753: Size comparison from 7eab378 to 5053bd7 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Feb 24, 2025
shubhamdp
approved these changes
Feb 25, 2025
|
@feasel0 should we enable the @andy31415 can we enable this all the time? Or use |
@shubhamdp I enabled the workflow in the initial commit, it passed the CI, and then I disabled it again. |
Thanks @feasel0 |
|
This PR added an EXPECT statement to check the result of UPDATE: Resolved. The test will expect false if locking is not supported. |
bzbarsky-apple
requested changes
Feb 27, 2025
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…37753) * Adds src/platform/tests into esp32-qemu-tests target * CI * Skip TryLockChipStack test on Darwin * Updated to use CHIP_SYSTEM_CONFIG_NO_LOCKING * Comment update * Expect statement checks if lock result matches "no locking" value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the unit tests
src/platform/testsinto theesp32-qemu-teststarget.Fixes a failure in
TryLockChipStackdue to a missing initialization step (Error log, line 150). This was not detected previously since the FreeRTOS implementation of PlatformMgr had been skipping deleting its data members during shutdown (which has since been fixed: #37489).Fixes a failure in
GetMonotonicMillisecondsdue toSleepMillisbeing less precise on esp32-qemu. Error log (line 76)Testing
Automated testing. Used the
ESP32_QEMUCI check, which now includeslibPlatformTests. Also manually built theesp32-qemu-teststarget and ran all images.Log after changes (0 failures)