Add the ability to add a diff for the file size differ
#37764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37764: Size comparison from 9298ce7 to 091cd09 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Feb 25, 2025
|
PR #37764: Size comparison from 9298ce7 to 06228b1 Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@gemini-code-assist review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces several new features and enhancements to the file size analysis tool. The addition of diffing capabilities, the icicle display type, and color options significantly improve the tool's utility and presentation. The code is generally well-structured, but there are a few areas where minor improvements can be made to enhance clarity and maintainability.
Summary of Findings
- Clarity of Symbol Diff Logic: The logic within
compute_symbol_diffcould benefit from additional comments to clarify the conditions under which symbols are considered different and how the size delta is calculated and applied. - Inconsistent use of Enum: The
ChartStyleEnum was removed and replaced with direct references topxfunctions. While this simplifies the code, it might be beneficial to maintain an Enum for clarity and potential future expansion. - Magic Numbers in Namespace Removal: The use of
separate_idx+2to remove namespaces could be made more explicit with a named constant or a comment explaining the+2offset.
Assessment
The pull request introduces several new features, including size differencing, an icicle display option, naming format updates, and color customization. The changes seem well-structured and the included screenshots demonstrate the functionality. However, there are a few areas where improvements can be made to enhance code clarity and maintainability. I recommend addressing the comments before merging, and ensuring that another reviewer approves this code before merging.
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…p#37764) * Start implementing a diff for symbols * Fix up size computations * make things run * Added icicles graph * Also add percent root to individual items * Show name sizes * Better name formatting * Restyled by autopep8 * Make linter happy * add assert for fetch values, clean up asserts a bit * Match statements seem easier to read and provable branches with static analysis * Cleaner code by using express everywhere * Shorter code * Allow some color control too * Restyled by autopep8 --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Ran locally, saw display like:
and
and