Add retransmission count to MRP TransmitEvent #37768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37768: Size comparison from ba98125 to 3807500 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Feb 25, 2025
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The changes look good overall. The addition of the retransmissionCount field to the TransmitEvent struct seems well-integrated and the unit tests have been updated accordingly. I have a minor suggestion regarding naming consistency in the test file.
Summary of Findings
- Naming Consistency: Consider renaming
forthTransmitEventtofourthTransmitEventinTestReliableMessageProtocol.cppfor better readability and consistency.
Assessment
The pull request introduces a new field retransmissionCount to the TransmitEvent struct, which provides valuable information for analyzing reliable message transmissions. The code changes are well-structured and include corresponding updates to the unit tests. Overall, the pull request is in good shape to be merged after addressing the minor suggestions provided below. Remember to have others review and approve this code before merging.
|
PR #37768: Size comparison from ba98125 to 8becdc8 Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -65,6 +67,9 @@ class ReliableMessageAnalyticsDelegate | |||
| // The outgoing message counter associated with the event. If there is no outgoing message counter | |||
| // this value will be 0. | |||
| uint32_t messageCounter = 0; | |||
| // If the eventType is kRetransmission, this value will be populated with the number of the | |||
| // retransmission attempt | |||
There was a problem hiding this comment.
This needs to document what "2" means: the first retransmission (i.e. the second packet sent), or the second retransmission (third packet sent).
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
* Add retransmission count to MRP TransmitEvent * Self review * Change forth to fourth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
New additions to unit test are passing