Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): Move CloseSession call after factory reset in TC_CGEN_2_8 #37776

Merged
merged 2 commits into from
Mar 6, 2025
Merged

fix(testing): Move CloseSession call after factory reset in TC_CGEN_2_8 #37776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84460e2
fix(testing): Move CloseSession call after factory reset in TC_CGEN_2_8
swan-amazon Feb 25, 2025
627b9a4
swan-amazon Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/python_testing/TC_CGEN_2_8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@ async def test_TC_CGEN_2_8(self):
"First CommissioningComplete failed",
)

# Close the commissioner session with the device to clean up resources
commissioner.CloseSession(nodeid=self.dut_node_id)

# Step 5: Factory reset is handled by test operator
self.step(5)
if not self.check_pics('PICS_USER_PROMPT'):
Expand All @@ -140,6 +137,9 @@ async def test_TC_CGEN_2_8(self):

self.wait_for_user_input(prompt_msg="Manually trigger factory reset on the DUT, then continue")

# Close the commissioner session with the device to clean up resources
commissioner.CloseSession(nodeid=self.dut_node_id)

# Step 6: Put device in commissioning mode (requiring user input, so skip in CI)
self.step(6)
self.wait_for_user_input(prompt_msg="Manually set the DUT into commissioning mode, then continue")
Expand Down
Loading