Remove C++ 17 workarounds for esp32. #37778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fail to compile currently with an error like: ``` CMake Error at CMakeLists.txt:83 (get_target_property): get_target_property() called with non-existent target "pw_build.cpp17._public_config". CMake Error at CMakeLists.txt:86 (set_target_properties): set_target_properties Can not find target to add properties to: pw_build.cpp17._public_config ``` The target of `_public_config` seems private so we should not mess with it. Tested that RPC compiles locally.
|
Review changes with |
|
PR #37778: Size comparison from b10a85a to f67955c Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shubhamdp
approved these changes
Feb 26, 2025
|
Fast track: compile seems ok (although we also do not seem to properly check for this in CI ... since otherwise it would have been broken before). |
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
These fail to compile currently with an error like: ``` CMake Error at CMakeLists.txt:83 (get_target_property): get_target_property() called with non-existent target "pw_build.cpp17._public_config". CMake Error at CMakeLists.txt:86 (set_target_properties): set_target_properties Can not find target to add properties to: pw_build.cpp17._public_config ``` The target of `_public_config` seems private so we should not mess with it. Tested that RPC compiles locally. Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fail to compile currently with an error like:
The target of
_public_configseems private so we should not mess with it. Tested that RPC compiles locally.Testing
Locally compiled with rpc using target
esp32-devkitc-light-rpc