Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate TemperatureControl Cluster XML with Alchemy and ZAP #37781

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Generate TemperatureControl Cluster XML with Alchemy and ZAP #37781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d500a1f
Generate TemperatureControl Cluster XML with Alchemy and ZAP
tersal Feb 26, 2025
0cb79a3
Restyled by whitespace
restyled-commits Feb 26, 2025
4a96730
Restyled by prettier-json
restyled-commits Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3388,7 +3388,7 @@ cluster RvcCleanMode = 85 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -3414,7 +3414,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2719,7 +2719,7 @@ cluster ModeSelect = 80 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -2745,7 +2745,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/chef/devices/rootnode_dishwasher_cc105034fe.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,7 +1420,7 @@ cluster GroupKeyManagement = 63 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -1446,7 +1446,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/chef/devices/rootnode_laundrydryer_01796fe396.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,7 +1420,7 @@ cluster GroupKeyManagement = 63 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -1446,7 +1446,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/chef/devices/rootnode_laundrywasher_fb10d238c8.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,7 +1442,7 @@ cluster LaundryWasherControls = 83 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -1468,7 +1468,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions ..._refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,7 +1340,7 @@ cluster RefrigeratorAndTemperatureControlledCabinetMode = 82 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -1366,7 +1366,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/laundry-washer-app/nxp/zap/laundry-washer-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,7 +1882,7 @@ cluster LaundryWasherControls = 83 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -1908,7 +1908,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/refrigerator-app/refrigerator-common/refrigerator-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,7 +1281,7 @@ cluster GroupKeyManagement = 63 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -1307,7 +1307,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1679,7 +1679,7 @@ cluster RefrigeratorAndTemperatureControlledCabinetMode = 82 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -1705,7 +1705,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,7 +1590,7 @@ cluster RefrigeratorAndTemperatureControlledCabinetMode = 82 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -1616,7 +1616,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
34 changes: 21 additions & 13 deletions src/app/zap-templates/zcl/data-model/chip/temperature-control-cluster.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<!--
Copyright (c) 2023 Project CHIP Authors
Copyright (c) 2023-2025 Project CHIP Authors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -14,9 +14,14 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<configurator>
<!--
XML generated by Alchemy; DO NOT EDIT.
Source: src/app_clusters/TemperatureControl.adoc
Parameters: in-progress
Git: 0.7-summer-2025-253-gd51479a48
-->
<configurator xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../zcl.xsd">
<domain name="CHIP"/>

<cluster>
<name>Temperature Control</name>
<domain>Appliances</domain>
Expand All @@ -25,7 +30,7 @@ limitations under the License.
<define>TEMPERATURE_CONTROL_CLUSTER</define>
<client tick="false" init="false">true</client>
<server tick="false" init="false">true</server>

<globalAttribute code="0xFFFD" side="either" value="1"/>
<features>
<feature bit="0" code="TN" name="TemperatureNumber" summary="Use actual temperature numbers">
<optionalConform choice="a"/>
Expand All @@ -39,44 +44,47 @@ limitations under the License.
</optionalConform>
</feature>
</features>

<attribute side="server" code="0x0000" name="TemperatureSetpoint" define="TEMP_SETPOINT" type="temperature" optional="true">
<description>TemperatureSetpoint</description>
<mandatoryConform>
<feature name="TN"/>
</mandatoryConform>
</attribute>
<attribute side="server" code="0x0001" name="MinTemperature" define="MIN_TEMP" type="temperature" optional="true">
<description>MinTemperature</description>
<mandatoryConform>
<feature name="TN"/>
</mandatoryConform>
</attribute>
<attribute side="server" code="0x0002" name="MaxTemperature" define="MAX_TEMP" type="temperature" optional="true">
<description>MaxTemperature</description>
<mandatoryConform>
<feature name="TN"/>
</mandatoryConform>
</attribute>
<attribute side="server" code="0x0003" name="Step" define="STEP" type="temperature" optional="true">
<description>Step</description>
<mandatoryConform>
<feature name="STEP"/>
</mandatoryConform>
</attribute>
<attribute side="server" code="0x0004" name="SelectedTemperatureLevel" define="SELECTED_TEMP_LEVEL" type="int8u" optional="true">
<attribute side="server" code="0x0004" name="SelectedTemperatureLevel" define="SELECTED_TEMP_LEVEL" type="int8u" optional="true" max="31">
<description>SelectedTemperatureLevel</description>
<mandatoryConform>
<feature name="TL"/>
</mandatoryConform>
</attribute>
<attribute side="server" code="0x0005" name="SupportedTemperatureLevels" define="SUPPORTED_TEMP_LEVELS" type="array" entryType="char_string" optional="true">
<attribute side="server" code="0x0005" name="SupportedTemperatureLevels" define="SUPPORTED_TEMP_LEVELS" type="array" entryType="char_string" optional="true" length="32">
<description>SupportedTemperatureLevels</description>
<mandatoryConform>
<feature name="TL"/>
</mandatoryConform>
</attribute>

<command source="client" code="0x00" name="SetTemperature" optional="false">
<description>Set Temperature</description>
<arg name="TargetTemperature" type="temperature" min="MIN_TEMP" max="MAX_TEMP" optional="true"/>
<arg name="TargetTemperatureLevel" type="int8u" optional="true"/>
<mandatoryConform/>
<description>The SetTemperature command SHALL have the following data fields: </description>
<arg id="0" name="TargetTemperature" type="temperature" optional="true"/>
<arg id="1" name="TargetTemperatureLevel" type="int8u" optional="true"/>
</command>
</cluster>

</cluster>
</configurator>
4 changes: 2 additions & 2 deletions src/controller/data_model/controller-clusters.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3606,7 +3606,7 @@ cluster RvcCleanMode = 85 {

/** Attributes and commands for configuring the temperature control, and reporting temperature. */
cluster TemperatureControl = 86 {
revision 1; // NOTE: Default/not specifically set
revision 1;

bitmap Feature : bitmap32 {
kTemperatureNumber = 0x1;
Expand All @@ -3632,7 +3632,7 @@ cluster TemperatureControl = 86 {
optional int8u targetTemperatureLevel = 1;
}

/** Set Temperature */
/** The SetTemperature command SHALL have the following data fields: */
command SetTemperature(SetTemperatureRequest): DefaultSuccess = 0;
}

Expand Down
2 changes: 1 addition & 1 deletion src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading