Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux] Restore required signals removed in 96bf5df #37806

Merged
merged 1 commit into from
Feb 27, 2025
Merged

[Linux] Restore required signals removed in 96bf5df #37806

merged 1 commit into from
Feb 27, 2025

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Feb 27, 2025 •
edited
Loading

Problem

By mistake some required signals were removed in the #37492

Also, it might be a fix for: #37802

Chnages

  • restored missing signals
  • changed properties-changed to g-properties-changed to use glib built-in support for org.freedesktop.DBus.Properties

Testing

Checked locally that there are no warnings like that:

(process:861): GLib-GObject-WARNING **: 18:47:51.180: ../../../gobject/gsignal.c:2620: signal 'interface-added' is invalid for instance '0x7fb400a8a0' of type 'WpaSupplicant1Proxy'

and ble-wifi commissioning works as expected:

rpi:~ $ chip-lighting-app --wifi

host:~$ out/linux-x64-chip-tool/chip-tool pairing ble-wifi 1 MATTER-AP password 20202021 3840

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

PR #37806: Size comparison from 4e7ce33 to 4d5572a

Increases above 0.2%:

platform target config section 4e7ce33 4d5572a change % change
linux air-purifier-app debug unknown 4728 4752 24 0.5
RAM 111088 112272 1184 1.1
all-clusters-app debug unknown 5536 5560 24 0.4
RAM 514832 516016 1184 0.2
all-clusters-minimal-app debug unknown 5432 5456 24 0.4
RAM 221272 222456 1184 0.5
bridge-app debug unknown 5448 5472 24 0.4
RAM 200144 201328 1184 0.6
camera-app debug unknown 5432 5456 24 0.4
RAM 194592 195776 1184 0.6
chip-tool debug unknown 6096 6112 16 0.3
fabric-admin debug unknown 5784 5800 16 0.3
fabric-bridge-app debug unknown 4696 4720 24 0.5
RAM 187016 188168 1152 0.6
fabric-sync debug unknown 4952 4976 24 0.5
RAM 470400 471584 1184 0.3
lighting-app debug+rpc+ui unknown 6160 6184 24 0.4
RAM 203952 205136 1184 0.6
lock-app debug unknown 5400 5424 24 0.4
RAM 191144 192328 1184 0.6
ota-provider-app debug unknown 4736 4760 24 0.5
RAM 179832 180984 1152 0.6
ota-requestor-app debug unknown 4688 4712 24 0.5
RAM 184320 185472 1152 0.6
shell debug unknown 4216 4240 24 0.6
RAM 144344 145528 1184 0.8
thermostat-no-ble arm64 RAM 229016 229832 816 0.4
tv-app debug unknown 5728 5752 24 0.4
tv-casting-app debug unknown 5304 5320 16 0.3
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4e7ce33 4d5572a change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096892 1096892 0 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651870 651870 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 829142 829142 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061538 1061538 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892382 892382 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975278 975278 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 817152 817152 0 0.0
RAM 120272 120272 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 826072 826072 0 0.0
RAM 125368 125368 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772956 772956 0 0.0
RAM 113740 113740 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 757240 757240 0 0.0
RAM 113948 113948 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540646 540646 0 0.0
RAM 205128 205128 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574794 574794 0 0.0
RAM 205376 205376 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 658861 658861 0 0.0
RAM 75412 75412 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 678713 678713 0 0.0
RAM 78052 78052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 678713 678713 0 0.0
RAM 78052 78052 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 635645 635645 0 0.0
RAM 70480 70480 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619101 619101 0 0.0
RAM 71652 71652 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638737 638737 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638737 638737 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 638589 638589 0 0.0
RAM 74660 74660 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 658305 658305 0 0.0
RAM 77204 77204 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 658305 658305 0 0.0
RAM 77204 77204 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614937 614937 0 0.0
RAM 68748 68748 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634789 634789 0 0.0
RAM 71388 71388 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634789 634789 0 0.0
RAM 71388 71388 0 0.0
efr32 lock-app BRD4187C FLASH 939672 939672 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 732656 732656 0 0.0
RAM 234828 234828 0 0.0
window-app BRD4187C FLASH 1032104 1032104 0 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 98656 98656 0 0.0
FLASH 1589616 1589616 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 117436 117436 0 0.0
FLASH 1556626 1556626 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4728 4752 24 0.5
FLASH 2651111 2653237 2126 0.1
RAM 111088 112272 1184 1.1
all-clusters-app debug unknown 5536 5560 24 0.4
FLASH 5962884 5965010 2126 0.0
RAM 514832 516016 1184 0.2
all-clusters-minimal-app debug unknown 5432 5456 24 0.4
FLASH 5297596 5299722 2126 0.0
RAM 221272 222456 1184 0.5
bridge-app debug unknown 5448 5472 24 0.4
FLASH 4649944 4652070 2126 0.0
RAM 200144 201328 1184 0.6
camera-app debug unknown 5432 5456 24 0.4
FLASH 4673072 4675198 2126 0.0
RAM 194592 195776 1184 0.6
chip-tool debug unknown 6096 6112 16 0.3
FLASH 13303567 13304951 1384 0.0
RAM 603392 603424 32 0.0
chip-tool-ipv6only arm64 unknown 21976 21976 0 0.0
FLASH 11496552 11497864 1312 0.0
RAM 656112 656128 16 0.0
fabric-admin debug unknown 5784 5800 16 0.3
FLASH 11568361 11569745 1384 0.0
RAM 603176 603208 32 0.0
fabric-bridge-app debug unknown 4696 4720 24 0.5
FLASH 4453510 4455636 2126 0.0
RAM 187016 188168 1152 0.6
fabric-sync debug unknown 4952 4976 24 0.5
FLASH 5570501 5572629 2128 0.0
RAM 470400 471584 1184 0.3
lighting-app debug+rpc+ui unknown 6160 6184 24 0.4
FLASH 5516785 5518913 2128 0.0
RAM 203952 205136 1184 0.6
lock-app debug unknown 5400 5424 24 0.4
FLASH 4689760 4691888 2128 0.0
RAM 191144 192328 1184 0.6
ota-provider-app debug unknown 4736 4760 24 0.5
FLASH 4311972 4314098 2126 0.0
RAM 179832 180984 1152 0.6
ota-requestor-app debug unknown 4688 4712 24 0.5
FLASH 4442292 4444418 2126 0.0
RAM 184320 185472 1152 0.6
shell debug unknown 4216 4240 24 0.6
FLASH 2980028 2982156 2128 0.1
RAM 144344 145528 1184 0.8
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4139576 4141656 2080 0.1
RAM 229016 229832 816 0.4
tv-app debug unknown 5728 5752 24 0.4
FLASH 5909349 5911477 2128 0.0
RAM 593832 595016 1184 0.2
tv-casting-app debug unknown 5304 5320 16 0.3
FLASH 11474045 11475437 1392 0.0
RAM 718656 718656 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 911760 911760 0 0.0
RAM 142859 142859 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 902608 902608 0 0.0
RAM 125195 125195 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 850424 850424 0 0.0
RAM 141271 141271 0 0.0
nxp contact k32w0+release FLASH 587368 587368 0 0.0
RAM 70980 70980 0 0.0
mcxw71+release FLASH 601192 601192 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 613100 613100 0 0.0
RAM 70268 70268 0 0.0
k32w1+release FLASH 685824 685824 0 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 750032 750032 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1655684 1655684 0 0.0
RAM 212264 212264 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1562380 1562380 0 0.0
RAM 208560 208560 0 0.0
light cy8ckit_062s2_43012 FLASH 1441180 1441180 0 0.0
RAM 197296 197296 0 0.0
lock cy8ckit_062s2_43012 FLASH 1470068 1470068 0 0.0
RAM 224960 224960 0 0.0
qpg lighting-app qpg6105+debug FLASH 663772 663772 0 0.0
RAM 105156 105156 0 0.0
lock-app qpg6105+debug FLASH 622240 622240 0 0.0
RAM 99768 99768 0 0.0
stm32 light STM32WB5MM-DK FLASH 459840 459840 0 0.0
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 669192 669192 0 0.0
RAM 90752 90752 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622078 622078 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745386 745386 0 0.0
RAM 40396 40396 0 0.0
tl7218x FLASH 753948 753948 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 681018 681018 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709580 709580 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600760 600760 0 0.0
RAM 138812 138812 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788988 788988 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1766136 1766136 0 0.0
RAM 93844 93844 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18983958 18983958 0 0.0
RAM 8306328 8306328 0 0.0

@mergify mergify bot merged commit e34015c into project-chip:master Feb 27, 2025
71 checks passed
@arkq arkq deleted the fix-wifi branch February 27, 2025 17:25
gmarcosb pushed a commit to gmarcosb/connectedhomeip that referenced this pull request Mar 4, 2025
@arkq @gmarcosb
[Linux] Restore required signals removed in 96bf5df (project-chip#37806)
67a4ec4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@saurabhst saurabhst saurabhst approved these changes

@tehampson tehampson tehampson approved these changes

Assignees
No one assigned
Labels
linux platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkq @andy31415 @saurabhst @tehampson