-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Implement the WifiInterface class structure for all Wi-Fi platforms #37810
Merged
mergify
merged 11 commits into
project-chip:master
from
mkardous-silabs:feature/wifi_interface_class
Mar 4, 2025
Merged
[Silabs] Implement the WifiInterface class structure for all Wi-Fi platforms #37810
mergify
merged 11 commits into
project-chip:master
from
mkardous-silabs:feature/wifi_interface_class
Mar 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #37810: Size comparison from dee2ac3 to 22914b1 Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
PR #37810: Size comparison from dee2ac3 to 526541a Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Rohan Sahay <103027015+rosahay-silabs@users.noreply.github.com>
PR #37810: Size comparison from dee2ac3 to 55bd5eb Increases above 0.2%:
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Mar 3, 2025
cecille
approved these changes
Mar 4, 2025
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…atforms (project-chip#37810) * Refactor structure for the SiWx platform * Fix compilation errors for WifiInterface * Update WifiInterface consummers * Wf200 transition to the WifiInterface class structure * Implement rs9116 wifi interface * Fix wf200 init * Fix 917 NCP * Clean up * Fix builds * Update src/platform/silabs/NetworkCommissioningWiFiDriver.cpp Co-authored-by: Rohan Sahay <103027015+rosahay-silabs@users.noreply.github.com> * Add error code to log --------- Co-authored-by: Rohan Sahay <103027015+rosahay-silabs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR finishes the Wifi Interface refactor structure. It creates the WifiInterface class that is inherited by all the Silabs Wi-Fi platform implementations.
The PR has no functionnal changes that impact behavior. The goal of the PR is just to restructure the code and add API documentation.
The next steps will be to improve the implementations of the different Wi-Fi platforms.
Testing
The PR has no functionnal changes; PR was validated with basic sanity.