Parametrize app-common zap-generated path #37816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parametrize app-common zap-generated path to allow building Matter using custom generated zap files stored in different path. When user adds custom clusters, full zap regeneration is needed. Storing these files in fixed place requires regeneration every time user wants to build different project (with different clusters). This commit allows to store zap-generated files separately and provide their path by seting `CHIP_APP_ZAP_DIR` cmake and `chip_app_zap_dir` GN flags. Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
|
PR #37816: Size comparison from 50aa1d3 to 9634dd7 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
adigie
approved these changes
Feb 28, 2025
maciejbaczmanski
changed the title
ArekBalysNordic
approved these changes
Mar 3, 2025
andy31415
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametrize app-common zap-generated path to allow building
Matter using custom generated zap files stored in different path.
When user adds custom clusters, full zap regeneration is needed.
Storing these files in fixed place requires regeneration every
time user wants to build different project (with different
clusters). This commit allows to store zap-generated files
separately and provide their path by seting
CHIP_APP_ZAP_DIRcmake and
chip_app_zap_dirGN flags.Testing
Tested locally on nrfconnect with custom clusters added and CHIP_APP_ZAP_DIR overridden, and with default clusters, with no CHIP_APP_ZAP_DIR override