Fix method naming and cleanup FailSafeContext #37820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #37820: Size comparison from 50aa1d3 to 7ad6c4b Full report (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
tcarmelveilleux
approved these changes
Feb 28, 2025
Commit marker was moved from FailSafeContext to FabricTable in project-chip#20010, however name of the key wasn't changed and it's misleading. This commit changes the name of the method returning commit marker key, but keeps the key name for backward compatibility. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
CommitToStorage was removed in project-chip#20010. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
|
PR #37820: Size comparison from 50aa1d3 to 4b13180 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Mar 1, 2025
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Mar 4, 2025
…-chip#37820) * Rename FailSafeCommitMarkerKey to FabricTableCommitMarkerKey Commit marker was moved from FailSafeContext to FabricTable in project-chip#20010, however name of the key wasn't changed and it's misleading. This commit changes the name of the method returning commit marker key, but keeps the key name for backward compatibility. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * Remove declaration of non-existent method CommitToStorage was removed in project-chip#20010. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> (cherry picked from commit 4c7bbe0)
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
* Rename FailSafeCommitMarkerKey to FabricTableCommitMarkerKey Commit marker was moved from FailSafeContext to FabricTable in project-chip#20010, however name of the key wasn't changed and it's misleading. This commit changes the name of the method returning commit marker key, but keeps the key name for backward compatibility. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * Remove declaration of non-existent method CommitToStorage was removed in project-chip#20010. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FailSafeCommitMarkerKeytoFabricTableCommitMarkerKeyFailSafeContext::CommitToStoragedeclaration - method was removedThis PR is a subset of #37807, which may require more work.
Testing
Tested by CI.