Add -Wl,--as-needed flag for all executable builds #37821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR#33628 has added an explicit link to libatomic for all linux-based builds to fix a build issue on mips. This results with a NEEDED record for libatomic.so.1 even when it's not required. One situation when this happens is building on arm64 with clang. Signed-off-by: Maciej Grela <m.grela@samsung.com>
andy31415
approved these changes
Feb 28, 2025
|
PR #37821: Size comparison from 50aa1d3 to 2a77907 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Signed-off-by: Maciej Grela <m.grela@samsung.com>
|
PR #37821: Size comparison from ab3d5ae to 670b297 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37821: Size comparison from fa36c44 to 1291a96 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
reviewed
Mar 3, 2025
arkq
approved these changes
Mar 3, 2025
Signed-off-by: Maciej Grela <m.grela@samsung.com>
|
PR #37821: Size comparison from 4e3f1cd to c377aac Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37821: Size comparison from 5aeae51 to fd66a70 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
gmarcosb
pushed a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2025
* build: Add -Wl,--as-needed flag for all executable builds PR#33628 has added an explicit link to libatomic for all linux-based builds to fix a build issue on mips. This results with a NEEDED record for libatomic.so.1 even when it's not required. One situation when this happens is building on arm64 with clang. Signed-off-by: Maciej Grela <m.grela@samsung.com> * gn: Restrict --as-needed to only Linux builds using clang Signed-off-by: Maciej Grela <m.grela@samsung.com> * typo Signed-off-by: Maciej Grela <m.grela@samsung.com> * gn: Blacklist instead of whitelist, include ios and explanatory comment Signed-off-by: Maciej Grela <m.grela@samsung.com> --------- Signed-off-by: Maciej Grela <m.grela@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#33628 has added an explicit link to libatomic for all linux-based builds to fix a build issue on mips.
This results with a NEEDED record for libatomic.so.1 even when it's not required. One situation when this happens is building on arm64 with clang.
Before:
After:
Testing
The binaries without libatomic.so.1 successfuly execute on arm64 ubuntu 24.04.2.