-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD]Trigger resubscription when receiving check-in and subscription has not yet become abnormal #37831
Open
yunhanw-google
wants to merge
10
commits into
project-chip:master
Choose a base branch
from
yunhanw-google:feature/30902
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ICD]Trigger resubscription when receiving check-in and subscription has not yet become abnormal #37831
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9f7bed7
Trigger resubscription when receiving check-in and subscription has n…
yunhanw-google 2a2df3e
fix OnPeerTypeChange
yunhanw-google e49f9a6
address comments
yunhanw-google 8dce4be
add monitor subject check for subscription activation
yunhanw-google 0860870
fix compilation
yunhanw-google 9cda649
introduce mCatsMatchCheckIn to indicate whether cats for icd registra…
yunhanw-google 287a093
address comments and add tests
yunhanw-google 2b29328
Restyled by whitespace
restyled-commits 6a97e2c
Restyled by clang-format
restyled-commits 1fca04a
address comments
yunhanw-google File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -351,11 +351,17 @@ class ReadClient : public Messaging::ExchangeDelegate | |
* Re-activate an inactive subscription. | ||
* | ||
* When subscribing to LIT-ICD and liveness timeout reached and OnResubscriptionNeeded returns | ||
* CHIP_ERROR_LIT_SUBSCRIBE_INACTIVE_TIMEOUT, the read client will move to the InactiveICDSubscription state and | ||
* resubscription can be triggered via OnActiveModeNotification(). | ||
* CHIP_ERROR_LIT_SUBSCRIBE_INACTIVE_TIMEOUT, the read client will move to the InactiveICDSubscription state and | ||
* resubscription can be triggered via OnActiveModeNotification(). | ||
* | ||
* If the subscription is not in the `InactiveICDSubscription` state, this function will do nothing. So it is always safe to | ||
* call this function when a check-in message is received. | ||
* call this function when a check-in message is received. | ||
* | ||
* If the server sends out check-in message, and there is a active tracked active subscription in client side at the same time, | ||
* it means current client does not realize this tracked subscription has gone, and we should forcibly timeout current | ||
* subscription, and schedule a new one. | ||
Comment on lines
+360
to
+362
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This comment does not match what the API actually does, really. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rewrite the comments, thanks |
||
* | ||
* This API only works when issuing subscription via SendAutoResubscribeRequest. | ||
*/ | ||
void OnActiveModeNotification(); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I am trying to understand why it's OK to remove this. The reason this seems to be here is that it's envisioning us having two subscriptions, one of which (call it A) is watching for peer type change and one of which (call it B) is IsInactiveICDSubscription(). When the transition to SIT is observed, B will no longer get any OnActiveModeNotifications, so how will it get out of the "inactive ICD subscription" state?
Of course if A does not exist and we just have B, and it's in the "inactive ICD subscription" state and then the server changes to A SIT, I think we just get stuck; that seems to be a hole in the whole logic of this stuff, including the spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, the current change does not work on the below scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the code.