Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a server cluster interface registry for use by codegen. #37850

Merged
merged 29 commits into from
Mar 6, 2025
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
f301851
Server cluster interface
andy31415 Mar 3, 2025
bb89093
ServerClusterInterfaceRegistry adding
andy31415 Mar 3, 2025
e238230
Merge branch 'master' into server-cluster-interface
andy31415 Mar 3, 2025
c3cb1aa
Merge branch 'server-cluster-interface' into server_cluster_registry
andy31415 Mar 3, 2025
bbb33e4
Merge branch 'master' into server_cluster_registry
andreilitvin Mar 4, 2025
7fdd6b4
Update src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
andy31415 Mar 4, 2025
0a6a7f9
Code review: forward declare
andreilitvin Mar 4, 2025
ab8a9b2
Review comment: switch order of members
andreilitvin Mar 4, 2025
d9aa48e
Updated logic: the condition is not relevant anymore
andreilitvin Mar 4, 2025
a062ca2
Code review: added comment
andreilitvin Mar 4, 2025
a92317c
Restyle
andreilitvin Mar 4, 2025
e73955c
Merge branch 'master' into server_cluster_registry
andreilitvin Mar 4, 2025
b60ebad
Comment update
andy31415 Mar 5, 2025
2daa37c
Updates to make callers use memory allocation
andreilitvin Mar 6, 2025
7a2bb76
Self review: fix an include
andreilitvin Mar 6, 2025
4e819fa
Fix constexpr logic
andreilitvin Mar 6, 2025
7da6312
Restyle
andreilitvin Mar 6, 2025
0c1bc26
minor comment update so github is not confused about head SHA
andreilitvin Mar 6, 2025
ea3e4d0
Added useless unit test to get coverage
andreilitvin Mar 6, 2025
86aeb05
Restyle
andreilitvin Mar 6, 2025
4fec4f1
Update src/app/server-cluster/ServerClusterInterface.h
andy31415 Mar 6, 2025
868d8a9
Update src/data-model-providers/codegen/ServerClusterInterfaceRegistr…
andy31415 Mar 6, 2025
30f5679
Update src/data-model-providers/codegen/ServerClusterInterfaceRegistr…
andy31415 Mar 6, 2025
c88e835
Update src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
andy31415 Mar 6, 2025
4ea82ec
Update src/data-model-providers/codegen/ServerClusterInterfaceRegistry.h
andy31415 Mar 6, 2025
af23a93
Disallow null ptr registrations
andreilitvin Mar 6, 2025
73c46b6
Merge branch 'server_cluster_registry' of github.com:andy31415/connec…
andreilitvin Mar 6, 2025
4463e95
Restyled by clang-format
restyled-commits Mar 6, 2025
2fa2125
Reworded based on code review
andreilitvin Mar 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/data-model-providers/codegen/ServerClusterInterfaceRegistr…
…y.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
  • Loading branch information
andy31415 and bzbarsky-apple authored Mar 6, 2025
commit 868d8a9bbb2b206aa707c15a63ed71063faddee1
Original file line number Diff line number Diff line change
@@ -83,7 +83,7 @@ ServerClusterInterface * ServerClusterInterfaceRegistry::Unregister(const Concre
mCachedInterface = nullptr;
}

current->next = nullptr; // some clearing
current->next = nullptr; // Make sure current does not look like part of a list.
return current->serverClusterInterface;
}

Loading