-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the use of the ServerClusterInterfaceRegistry in Codegen Provider #37851
Merged
mergify
merged 19 commits into
project-chip:master
from
andy31415:use_server_cluster_interface_in_codegen
Mar 7, 2025
Merged
Enable the use of the ServerClusterInterfaceRegistry in Codegen Provider #37851
mergify
merged 19 commits into
project-chip:master
from
andy31415:use_server_cluster_interface_in_codegen
Mar 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a7cc5e
to
4b503a9
Compare
5a4e0c8
to
f959226
Compare
PR #37851: Size comparison from b38c5b8 to 86f46e5 Full report (3 builds for cc32xx, stm32)
|
src/data-model-providers/codegen/ServerClusterInterfaceRegistry.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #37851: Size comparison from b38c5b8 to 7e25e3f Full report (16 builds for bl602, bl702, bl702l, esp32, linux, nxp, stm32)
|
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #37851: Size comparison from b38c5b8 to 29a1502 Full report (7 builds for bl602, bl702, bl702l, stm32)
|
PR #37851: Size comparison from b38c5b8 to 33fad9c Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Mar 7, 2025
PR #37851: Size comparison from b38c5b8 to 806081a Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
PR #37851: Size comparison from b38c5b8 to 3635171 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Mar 7, 2025
gmarcosb
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes that ServerClusterInterface are fully handling read/write/invoke (i.e. no more fallback or "not implemented" as the AAI/CHI supports).
This is to assess code increases and code style.
Contains all changes from #37850 and that one should probably be merged and considered first.
General changes:
Testing