-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clang-tidy error in PersistedCounter.h #37855
Merged
mergify
merged 1 commit into
project-chip:master
from
adigie:fix-clang-tidy-persisted-counter
Mar 6, 2025
Merged
Fix clang-tidy error in PersistedCounter.h #37855
mergify
merged 1 commit into
project-chip:master
from
adigie:fix-clang-tidy-persisted-counter
Mar 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #37855: Size comparison from 48b4fed to 97b2ad1 Full report (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #37855: Size comparison from 48b4fed to 9d4d469 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
9d4d469
to
6023406
Compare
PR #37855: Size comparison from 1612d52 to 6023406 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
6023406
to
2b0e009
Compare
PR #37855: Size comparison from 13da787 to 2b0e009 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Mar 4, 2025
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
2b0e009
to
8d03e77
Compare
PR #37855: Size comparison from 5becd81 to 8d03e77 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ArekBalysNordic
approved these changes
Mar 6, 2025
8d03e77
to
5fe1ba8
Compare
Damian-Nordic
approved these changes
Mar 6, 2025
PR #37855: Size comparison from 1eb2421 to 5fe1ba8 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign 0 to suppress the warning. In case of error, the value wont't be used anyway.
Fixes #37854.
Testing
Tested by CI
https://github.com/project-chip/connectedhomeip/actions/runs/13675355334/job/38234550494?pr=37855