TC-FAN-2.1: Enhanced attribute value testing #37863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raul-marquez-csa
requested review from
cecille,
gvargas-csa,
j-ororke and
andy31415
|
PR #37863: Size comparison from 13da787 to 63d1d51 Full report (74 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
This works on my WSL setup locally.
Had some issues with building the air-purifier app in my local setup to get this to run, but got that app to build after making some minor modifications to examples/air-purifier-app/air-purifier-common/include/air-purifier-manager.h as @raul-marquez-csa had mentioned is needed during the test and infra team call.
cecille
reviewed
Mar 6, 2025
| @@ -0,0 +1,167 @@ | |||
| # | |||
| # Copyright (c) 2024 Project CHIP Authors | |||
There was a problem hiding this comment.
Does this do anything different than the YAML right now?
There was a problem hiding this comment.
Yes, it checks FanModeSequence conformance.
It verifies that if FanMode is in Auto, the FanModeSequence has a value that supports Auto.
|
PR #37863: Size comparison from 652f786 to 56a9e0d Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
raul-marquez-csa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Addresses TC-FAN-2.1 from issue
[TC-FAN] Fan tests do not sufficiently test attribute interactions #4788
- Fan mode sequence isn't checked for conformance with the auto mode
This is a YAML to Python port
Enhancement testing update
Verifies that when the
FanModeattribute is in Auto mode, theFanModeSequenceattribute has a value that supports Auto mode.Fan Control spec
Corresponding test plan PR - Preview