[ICD] Expose SetModeDurations via ICDManager #37887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
changed the title
github-actions
bot
added
documentation
yunhanw-google
force-pushed
the
feature/SetModeDuration
branch
from
654247b to
5e653df
Compare
|
PR #37887: Size comparison from 2aaf2f8 to 5e653df Full report (26 builds for cc13x4_26x4, cc32xx, linux, stm32, tizen)
|
yunhanw-google
force-pushed
the
feature/SetModeDuration
branch
from
5e653df to
9cffc81
Compare
|
PR #37887: Size comparison from cf45d5d to 9cffc81 Full report (9 builds for cc13x4_26x4, cc32xx, stm32, tizen)
|
yunhanw-google
force-pushed
the
feature/SetModeDuration
branch
from
9cffc81 to
64f23b2
Compare
|
PR #37887: Size comparison from cf45d5d to 64f23b2 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Mar 6, 2025
yunhanw-google
force-pushed
the
feature/SetModeDuration
branch
from
64f23b2 to
09d2bbc
Compare
|
PR #37887: Size comparison from cf45d5d to 09d2bbc Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
yufengwangca
approved these changes
Mar 6, 2025
|
PR #37887: Size comparison from cf45d5d to 1682b12 Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
yunhanw-google
force-pushed
the
feature/SetModeDuration
branch
from
1682b12 to
9dab068
Compare
|
PR #37887: Size comparison from 1eb2421 to 9dab068 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -174,6 +174,13 @@ class ICDManager : public ICDListener, public TestEventTriggerHandler | |||
| */ | |||
| bool SupportsFeature(Clusters::IcdManagement::Feature feature); | |||
|
|
|||
| // See ICDConfigurationData::SetModeDurations | |||
| CHIP_ERROR SetModeDurations(Optional<System::Clock::Milliseconds32> activeModeDuration, | |||
There was a problem hiding this comment.
should these be const & instead of passed by value?
| @@ -174,6 +174,13 @@ class ICDManager : public ICDListener, public TestEventTriggerHandler | |||
| */ | |||
| bool SupportsFeature(Clusters::IcdManagement::Feature feature); | |||
|
|
|||
| // See ICDConfigurationData::SetModeDurations | |||
| CHIP_ERROR SetModeDurations(Optional<System::Clock::Milliseconds32> activeModeDuration, | |||
There was a problem hiding this comment.
Adding a comment that this API doesn't currently garantee that spec compliance is respected if called at run time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need expose SetModeDurations via ICDManager because
-- Chef icd example app need to update ModeDuration via parameter without rebuilding the example app binary.(see #37123 (comment))
-- the new ICD "finished" feature would use this code path
Testing
Update the existing unit test.