refactor: Rename CloseSession to MarkSessionDefunct and add MarkSessi… #37903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onForEviction This commit renames the Python function CloseSession to MarkSessionDefunct to better reflect its actual behavior and align with the C++ API. The function marks a session as temporarily defunct when there's a suspected loss of synchronization with the peer, but allows the session to become active again if messages are received. Additionally, adds a new function MarkSessionForEviction that permanently marks a session for removal by detaching all SessionHolders and releasing references, which will deallocate the session if no references remain. Once marked for eviction, the session can never become active again. Both functions have been properly documented to explain their behavior, parameters, and differences. All references to CloseSession throughout the codebase have been updated to use MarkSessionDefunct.
andy31415
approved these changes
Mar 6, 2025
|
PR #37903: Size comparison from 607fdca to d8d1756 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Mar 6, 2025
tcarmelveilleux
approved these changes
Mar 6, 2025
…sion-for-eviction
|
PR #37903: Size comparison from 7d7d638 to 0e3594e Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onForEviction
This commit renames the Python function CloseSession to MarkSessionDefunct to better reflect its actual behavior and align with the C++ API. The function marks a session as temporarily defunct when there's a suspected loss of synchronization with the peer, but allows the session to become active again if messages are received.
Additionally, adds a new function MarkSessionForEviction that permanently marks a session for removal by detaching all SessionHolders and releasing references, which will deallocate the session if no references remain. Once marked for eviction, the session can never become active again.
Both functions have been properly documented to explain their behavior, parameters, and differences. All references to CloseSession throughout the codebase have been updated to use MarkSessionDefunct.
Testing
Environment Setup
PICS_USER_PROMPT=1to enable interactive command-line prompts during test executionTest Execution Steps
Initial DUT Launch:
rm /tmp/chip* ./out/linux-x64-terms-and-conditions/chip-terms-and-conditions-app \ --version 0 \ --custom-flow 2 \ --capabilities 6 \ --discriminator 3840 \ --passcode 20202021 \ --KVS /tmp/chip_kvs.bin \ --trace_file /tmp/chip_trace.log \ --trace_log 1 \ --trace_decode 1 \ --vendor-id 0xfff1 \ --product-id 0x8012Test Script Execution
python3 src/python_testing/TC_CGEN_2_8.py \ --storage-path admin_storage.json \ --int-arg PIXIT.CGEN.FailsafeExpiryLengthSeconds:900 \ PIXIT.CGEN.RequiredTCAcknowledgements:1 \ PIXIT.CGEN.TCRevision:1 \ --qr-code MT:-24J08M.00KA0648G00 \ --PICS src/app/tests/suites/certification/ci-pics-values \ --in-test-commissioning-method on-networkFactory Reset Simulation:
Results