Generate PressureMeasurement cluster XML with Alchemy #37926
+17
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersal
changed the title
|
PR #37926: Size comparison from d5d2f72 to 07c7ce5 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
tersal
changed the title
| <mandatoryConform/> | ||
| </attribute> | ||
| <attribute side="server" code="0x0003" name="Tolerance" define="PRESSURE_TOLERANCE" type="int16u" min="0x0000" max="0x0800" optional="true" default="0"> | ||
| <attribute side="server" code="0x0000" name="MeasuredValue" define="PRESSURE_MEASURED_VALUE" type="int16s" isNullable="true" max="32767">MeasuredValue</attribute> |
There was a problem hiding this comment.
Why is this 'max' value there? This is just the max for the type... Why does it need to be listed explicitly?
There was a problem hiding this comment.
I got some feedback from @hasty regarding this, it seems that 'max' should only be listed if it is different from the default max value for the specific type, I'll take a look at what are the expected 'default' values for int16 in the project, 32767 seems to be the max for the a int16 type but I'm not sure if that matches the default here.
There was a problem hiding this comment.
The "default" max for int16 is 32767.
There was a problem hiding this comment.
Yes, this was a redundant "max" value, generated again with new Alchemy to remove those
|
PR #37926: Size comparison from 5adee57 to 6738adb Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37391
Code generation of Pressure measurement cluster with Alchemy.
Testing
Passed Unit Test and CI checks with Python and YAML tests.