Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in XPC version of invokeCommands. #37934

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Fix error handling in XPC version of invokeCommands. #37934

merged 1 commit into from
Mar 8, 2025

Conversation

bzbarsky-apple
Copy link
Contributor

Two issues:

  1. If we got an error we did not log it.
  2. If we got an error we did not actually propagate it out to the API consumer.

Testing

Manual testing that devices still work, but not sure how to test this error path.

@bzbarsky-apple
Fix error handling in XPC version of invokeCommands.
311a044 
Two issues:

1. If we got an error we did not log it.
2. If we got an error we did not actually propagate it out to the API consumer.
@bzbarsky-apple bzbarsky-apple requested a review from a team as a code owner March 7, 2025 22:18
@github-actions github-actions bot added the darwin label Mar 7, 2025
@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific fix with platform owner review.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

PR #37934: Size comparison from 36a1bbd to 311a044

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 36a1bbd 311a044 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098140 1098140 0 0.0
RAM 94866 94866 0 0.0
bl702 lighting-app bl702+eth FLASH 653118 653118 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830390 830390 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1062788 1062788 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 893630 893630 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 976526 976526 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818184 818184 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827104 827104 0 0.0
RAM 125392 125392 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 773972 773972 0 0.0
RAM 113764 113764 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 758248 758248 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 541758 541758 0 0.0
RAM 205152 205152 0 0.0
lock CC3235SF_LAUNCHXL FLASH 575866 575866 0 0.0
RAM 205400 205400 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 659885 659885 0 0.0
RAM 75436 75436 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 679745 679745 0 0.0
RAM 78076 78076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 679745 679745 0 0.0
RAM 78076 78076 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 636677 636677 0 0.0
RAM 70504 70504 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620133 620133 0 0.0
RAM 71676 71676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639769 639769 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639769 639769 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 639621 639621 0 0.0
RAM 74684 74684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659337 659337 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659337 659337 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615961 615961 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635821 635821 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635821 635821 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 940680 940680 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 734360 734360 0 0.0
RAM 234856 234856 0 0.0
window-app BRD4187C FLASH 1033232 1033224 -8 -0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 98728 98728 0 0.0
FLASH 1594328 1594328 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 117524 117524 0 0.0
FLASH 1560882 1560882 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2658609 2658609 0 0.0
RAM 112304 112304 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5980218 5980218 0 0.0
RAM 516760 516760 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5316602 5316602 0 0.0
RAM 222680 222680 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4630392 4630392 0 0.0
RAM 201000 201000 0 0.0
camera-app debug unknown 5456 5456 0 0.0
FLASH 4680486 4680486 0 0.0
RAM 195808 195808 0 0.0
camera-controller debug unknown 5776 5776 0 0.0
FLASH 11315673 11315673 0 0.0
RAM 596304 596304 0 0.0
chip-tool debug unknown 6112 6112 0 0.0
FLASH 13338515 13338515 0 0.0
RAM 605184 605184 0 0.0
chip-tool-ipv6only arm64 unknown 22072 22072 0 0.0
FLASH 11524744 11524744 0 0.0
RAM 657904 657904 0 0.0
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 11609301 11609301 0 0.0
RAM 604968 604968 0 0.0
fabric-bridge-app debug unknown 4720 4720 0 0.0
FLASH 4461378 4461378 0 0.0
RAM 188200 188200 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5578501 5578501 0 0.0
RAM 472032 472032 0 0.0
lighting-app debug+rpc+ui unknown 6192 6192 0 0.0
FLASH 5524689 5524689 0 0.0
RAM 205168 205168 0 0.0
lock-app debug unknown 5424 5424 0 0.0
FLASH 4697168 4697168 0 0.0
RAM 192360 192360 0 0.0
ota-provider-app debug unknown 4760 4760 0 0.0
FLASH 4319314 4319314 0 0.0
RAM 181016 181016 0 0.0
ota-requestor-app debug unknown 4712 4712 0 0.0
FLASH 4449698 4449698 0 0.0
RAM 185504 185504 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 2956924 2956924 0 0.0
RAM 145456 145456 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4145752 4145752 0 0.0
RAM 229848 229848 0 0.0
tv-app debug unknown 5752 5752 0 0.0
FLASH 5917365 5917365 0 0.0
RAM 595464 595464 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11510173 11510173 0 0.0
RAM 720736 720736 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915736 915736 0 0.0
RAM 142881 142881 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 908784 908784 0 0.0
RAM 125221 125221 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852556 852556 0 0.0
RAM 141243 141243 0 0.0
nxp contact k32w0+release FLASH 588288 588288 0 0.0
RAM 71004 71004 0 0.0
mcxw71+release FLASH 603512 603512 0 0.0
RAM 63144 63144 0 0.0
light k32w0+release FLASH 614084 614084 0 0.0
RAM 70292 70292 0 0.0
k32w1+release FLASH 687608 687608 0 0.0
RAM 72056 72056 0 0.0
lock mcxw71+release FLASH 752376 752376 0 0.0
RAM 67556 67556 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661284 1661284 0 0.0
RAM 212344 212344 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1565564 1565564 0 0.0
RAM 208560 208560 0 0.0
light cy8ckit_062s2_43012 FLASH 1442300 1442300 0 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471196 1471196 0 0.0
RAM 224984 224984 0 0.0
qpg lighting-app qpg6105+debug FLASH 664796 664796 0 0.0
RAM 105180 105180 0 0.0
lock-app qpg6105+debug FLASH 623256 623256 0 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 460872 460872 0 0.0
RAM 141496 141496 0 0.0
telink bridge-app tl7218x FLASH 665678 665678 0 0.0
RAM 90712 90712 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623260 623260 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 762034 762034 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 755142 755142 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 682192 682192 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710750 710750 0 0.0
RAM 73400 73400 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 703300 703300 0 0.0
RAM 37664 37664 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602870 602870 0 0.0
RAM 138640 138640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 790158 790158 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1782840 1782840 0 0.0
RAM 94168 94168 0 0.0
chip-tool-ubsan arm unknown 11536 11536 0 0.0
FLASH 19055430 19055430 0 0.0
RAM 8332308 8332308 0 0.0

@mergify mergify bot merged commit 652f786 into project-chip:master Mar 8, 2025
70 checks passed
@bzbarsky-apple bzbarsky-apple deleted the xpc-invokeresponses-error branch March 8, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@kiel-apple kiel-apple kiel-apple approved these changes

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @woody-apple @kiel-apple