zap generated files for Meter Identification cluster #37952
+7,230
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
PR #37952: Size comparison from 714907e to 86c1278 Increases above 0.2%:
Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
popovdg
force-pushed
the
meter_identification-XML
branch
from
86c1278 to
22239be
Compare
|
PR #37952: Size comparison from 59c205c to 22239be Increases above 0.2%:
Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
popovdg
force-pushed
the
meter_identification-XML
branch
from
22239be to
eb7904c
Compare
|
PR #37952: Size comparison from b56134c to eb7904c Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Mar 11, 2025
Comment on lines
32
to
33
| <enum name="PowerThresholdSourceEnum" type="enum8"> | ||
| <cluster code="0x0B06"/> |
There was a problem hiding this comment.
This does not match the spec. In the spec this is not a cluster-specific type.
There was a problem hiding this comment.
This does not match the spec. In the spec this is not a cluster-specific type.
Fixed.
Comment on lines
39
to
40
| <struct name="PowerThresholdStruct" apiMaturity="provisional"> | ||
| <cluster code="0x0B06"/> |
There was a problem hiding this comment.
Does not match the spec.
There was a problem hiding this comment.
Does not match the spec.
Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zap generated files for Meter Identification cluster are added.