-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Mandatory Endpoint Composition to Oven Device Type for ZAP XML #37954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
approved these changes
Mar 10, 2025
PR #37954: Size comparison from 714907e to 6a2adc5 Full report (10 builds for cc32xx, nrfconnect, qpg, stm32, tizen)
|
6a2adc5
to
3465b5b
Compare
PR #37954: Size comparison from 59c205c to 3465b5b Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Mar 10, 2025
…requires a minimum of one Temperature Controlled Cabinet on a separate endpoint.
PR #37954: Size comparison from 3e9b41b to 821bd89 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Mar 28, 2025
…project-chip#37954) * Adding Mandatory Endpoint Composition to Oven Device Type because it requires a minimum of one Temperature Controlled Cabinet on a separate endpoint. * add cooktop device type requirement to oven device type
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Mar 28, 2025
…project-chip#37954) * Adding Mandatory Endpoint Composition to Oven Device Type because it requires a minimum of one Temperature Controlled Cabinet on a separate endpoint. * add cooktop device type requirement to oven device type
hasty
pushed a commit
to hasty/connectedhomeip
that referenced
this pull request
Apr 2, 2025
…project-chip#37954) * Adding Mandatory Endpoint Composition to Oven Device Type because it requires a minimum of one Temperature Controlled Cabinet on a separate endpoint. * add cooktop device type requirement to oven device type
soares-sergio
pushed a commit
to soares-sergio/connectedhomeip
that referenced
this pull request
Apr 8, 2025
…project-chip#37954) * Adding Mandatory Endpoint Composition to Oven Device Type because it requires a minimum of one Temperature Controlled Cabinet on a separate endpoint. * add cooktop device type requirement to oven device type
sayondeep
pushed a commit
to sayondeep/connectedhomeip
that referenced
this pull request
Apr 10, 2025
…project-chip#37954) * Adding Mandatory Endpoint Composition to Oven Device Type because it requires a minimum of one Temperature Controlled Cabinet on a separate endpoint. * add cooktop device type requirement to oven device type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
The update to Oven Device Type in ZAP XML requires at least one Temperature Controlled Cabinet on a separate endpoint and ZAP must consume composition type.
ZAP Requirements:
Composite Device Identification: ZAP must know the "composite device" (device type with the endpointComposition tag) to accurately manage its composition.
Endpoint Requirements: ZAP must be aware of which device types require a new endpoint to ensure proper integration and functionality.
Mandatory Device Tracking: ZAP must have visibility into which devices are considered "mandatory" to ensure that all necessary devices are included in the composition and are correctly handled.