Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[darwin-framework-tool] Use NSURLSession instead of the NetworkFramew… #37964

Merged
merged 1 commit into from
Mar 12, 2025
Merged

[darwin-framework-tool] Use NSURLSession instead of the NetworkFramew… #37964

merged 1 commit into from
Mar 12, 2025

Conversation

vivien-apple
Copy link
Contributor

…ork for reading DCL content

The current implementation of HTTP requests in darwin-framework-tool uses the Network framework for handling HTTPS communication. However, this introduces unnecessary complexity.

This patch refactors the code to use NSURLSession, which simplifies the implementation while maintaining support for various security modes:

  • Default TLS validation (secure HTTPS)
  • TLS validation disabled (for cases where strict certificate validation is not required)
  • HTTP support (when HTTPS is explicitly disabled)

Testing

I have used the steps from #37379 to verify that it still works.

@vivien-apple vivien-apple self-assigned this Mar 11, 2025
@vivien-apple vivien-apple requested a review from a team as a code owner March 11, 2025 15:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

PR #37964: Size comparison from 1114858 to 2d53386

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 1114858 2d53386 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098296 1098296 0 0.0
RAM 94866 94866 0 0.0
bl702 lighting-app bl702+eth FLASH 653274 653274 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830546 830546 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1062944 1062944 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 893786 893786 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 976682 976682 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818264 818264 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827176 827176 0 0.0
RAM 125392 125392 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774036 774036 0 0.0
RAM 113764 113764 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 758320 758320 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 541830 541830 0 0.0
RAM 205152 205152 0 0.0
lock CC3235SF_LAUNCHXL FLASH 575930 575930 0 0.0
RAM 205400 205400 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 659957 659957 0 0.0
RAM 75436 75436 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 679809 679809 0 0.0
RAM 78076 78076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 679809 679809 0 0.0
RAM 78076 78076 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 636741 636741 0 0.0
RAM 70504 70504 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620189 620189 0 0.0
RAM 71676 71676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639833 639833 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639833 639833 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 639693 639693 0 0.0
RAM 74684 74684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659417 659417 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659417 659417 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616041 616041 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635893 635893 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635893 635893 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 940776 940776 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 734440 734440 0 0.0
RAM 234856 234856 0 0.0
window-app BRD4187C FLASH 1033320 1033312 -8 -0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 98728 98728 0 0.0
FLASH 1594366 1594366 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 117524 117524 0 0.0
FLASH 1560970 1560970 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2659017 2659017 0 0.0
RAM 112304 112304 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5980580 5980580 0 0.0
RAM 516696 516696 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5317024 5317024 0 0.0
RAM 222680 222680 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4630812 4630812 0 0.0
RAM 201000 201000 0 0.0
camera-app debug unknown 5456 5456 0 0.0
FLASH 4680896 4680896 0 0.0
RAM 195808 195808 0 0.0
camera-controller debug unknown 5776 5776 0 0.0
FLASH 11345413 11345413 0 0.0
RAM 597312 597312 0 0.0
chip-tool debug unknown 6112 6112 0 0.0
FLASH 13365471 13365471 0 0.0
RAM 605952 605952 0 0.0
chip-tool-ipv6only arm64 unknown 22120 22120 0 0.0
FLASH 11551288 11551288 0 0.0
RAM 658632 658632 0 0.0
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 1163666 1163666 0 0.0
RAM 605736 605736 0 0.0
fabric-bridge-app debug unknown 4720 4720 0 0.0
FLASH 4461800 4461800 0 0.0
RAM 188200 188200 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5578885 5578885 0 0.0
RAM 471968 471968 0 0.0
lighting-app debug+rpc+ui unknown 6192 6192 0 0.0
FLASH 5525105 5525105 0 0.0
RAM 205168 205168 0 0.0
lock-app debug unknown 5424 5424 0 0.0
FLASH 4697588 4697588 0 0.0
RAM 192360 192360 0 0.0
ota-provider-app debug unknown 4760 4760 0 0.0
FLASH 4319734 4319734 0 0.0
RAM 181016 181016 0 0.0
ota-requestor-app debug unknown 4712 4712 0 0.0
FLASH 4450118 4450118 0 0.0
RAM 185504 185504 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 2957340 2957340 0 0.0
RAM 145456 145456 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4146712 4146712 0 0.0
RAM 229848 229848 0 0.0
tv-app debug unknown 5752 5752 0 0.0
FLASH 5917765 5917765 0 0.0
RAM 595400 595400 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11537997 11537997 0 0.0
RAM 721744 721744 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915796 915796 0 0.0
RAM 144929 144929 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 908836 908836 0 0.0
RAM 123173 123173 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852628 852628 0 0.0
RAM 141243 141243 0 0.0
nxp contact k32w0+release FLASH 588336 588336 0 0.0
RAM 71004 71004 0 0.0
mcxw71+release FLASH 603560 603560 0 0.0
RAM 63144 63144 0 0.0
light k32w0+release FLASH 614132 614132 0 0.0
RAM 70292 70292 0 0.0
k32w1+release FLASH 687680 687680 0 0.0
RAM 72056 72056 0 0.0
lock mcxw71+release FLASH 752456 752456 0 0.0
RAM 67556 67556 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661332 1661332 0 0.0
RAM 212344 212344 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1565644 1565644 0 0.0
RAM 208560 208560 0 0.0
light cy8ckit_062s2_43012 FLASH 1442380 1442380 0 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471276 1471276 0 0.0
RAM 224984 224984 0 0.0
qpg lighting-app qpg6105+debug FLASH 664876 664876 0 0.0
RAM 105180 105180 0 0.0
lock-app qpg6105+debug FLASH 623328 623328 0 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 460952 460952 0 0.0
RAM 141496 141496 0 0.0
telink bridge-app tl7218x FLASH 665726 665726 0 0.0
RAM 90712 90712 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623308 623308 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 762082 762082 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 755190 755190 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 682240 682240 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710798 710798 0 0.0
RAM 73400 73400 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 703348 703348 0 0.0
RAM 37664 37664 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602918 602918 0 0.0
RAM 138640 138640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 790206 790206 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1783196 1783196 0 0.0
RAM 94168 94168 0 0.0
chip-tool-ubsan arm unknown 11560 11560 0 0.0
FLASH 19092774 19092774 0 0.0
RAM 8355048 8355048 0 0.0

@mergify mergify bot merged commit 4d9b423 into project-chip:master Mar 12, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@kiel-apple kiel-apple kiel-apple approved these changes

Assignees

@vivien-apple vivien-apple

Labels
darwin examples fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @woody-apple @kiel-apple