-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Added additonal advertising data for 917 SoC #38052
base: master
Are you sure you want to change the base?
[Silabs] Added additonal advertising data for 917 SoC #38052
Conversation
PR #38052: Size comparison from 52d8e11 to f87e65d Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #38052: Size comparison from 132a7a8 to a6f6626 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
PR #38052: Size comparison from 132a7a8 to d1992a4 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #38052: Size comparison from 79da246 to 6257ec7 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
@@ -71,6 +71,17 @@ extern "C" { | |||
#define RSI_BLE_CHARACTERISTIC_TX_MEASUREMENT_HANDLE_LOCATION (4) | |||
#define RSI_BLE_CHARACTERISTIC_TX_GATT_SERVER_CLIENT_HANDLE_LOCATION (5) | |||
|
|||
#ifdef CHIP_ENABLE_ADDITIONAL_DATA_ADVERTISING | |||
#define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_SIZE (16) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this size of 16 represent? Is this the data length C3 should 512.
#define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_VALUE_128_DATA_1 0x64630238 | ||
#define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_VALUE_128_DATA_2 0x8772 | ||
#define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_VALUE_128_DATA_3 0x45f2 | ||
#define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_VALUE_128_DATA_4 0x7D, 0xB8, 0x8A, 0x74, 0x04, 0x8F, 0x21, 0x83 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to clarify that this is the UUID either by renaming the define or with comments.
Also, why is the format different for data4 than the other data{1..3}.
@@ -949,6 +949,7 @@ CHIP_ERROR BLEManagerImpl::EncodeAdditionalDataTlv() | |||
|
|||
err = AdditionalDataPayloadGenerator().generateAdditionalDataPayload(additionalDataPayloadParams, c3AdditionalDataBufferHandle, | |||
additionalDataFields); | |||
SuccessOrExit(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we adding this here? we are already at the exit
SuccessOrExit(err); |
Description
The 917 BleManager does not support the C3 read request which is necessary to support the additional data advertising feature.
Added C3 characteristic to the matter service.
Testing
Enabled chip_enable_additional_data_advertising while building application and verified C3 characteristic has been added after connecting to the device and able to read C3 request by enable/disable READ .