[Silabs] Added additonal advertising data for 917 SoC #38052
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38052: Size comparison from 52d8e11 to f87e65d Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38052: Size comparison from 132a7a8 to a6f6626 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #38052: Size comparison from 132a7a8 to d1992a4 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38052: Size comparison from 79da246 to 6257ec7 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -71,6 +71,17 @@ extern "C" { | |||
| #define RSI_BLE_CHARACTERISTIC_TX_MEASUREMENT_HANDLE_LOCATION (4) | |||
| #define RSI_BLE_CHARACTERISTIC_TX_GATT_SERVER_CLIENT_HANDLE_LOCATION (5) | |||
|
|
|||
| #ifdef CHIP_ENABLE_ADDITIONAL_DATA_ADVERTISING | |||
| #define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_SIZE (16) | |||
There was a problem hiding this comment.
what does this size of 16 represent? Is this the data length C3 should 512.
There was a problem hiding this comment.
It is Size of UUID in bytes ,here 128-bit (16-byte) UUID.
There was a problem hiding this comment.
Please add this info with a relevant define name or comment
RSI_BLE_CUSTOM_CHARACTERISTIC_C3_UUID_SIZE would be better
but i'd also say RSI_BLE_CUSTOM_CHARACTERISTIC is a long prefix
Comment on lines
+77
to
+80
| #define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_VALUE_128_DATA_1 0x64630238 | ||
| #define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_VALUE_128_DATA_2 0x8772 | ||
| #define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_VALUE_128_DATA_3 0x45f2 | ||
| #define RSI_BLE_CUSTOM_CHARACTERISTIC_C3_VALUE_128_DATA_4 0x7D, 0xB8, 0x8A, 0x74, 0x04, 0x8F, 0x21, 0x83 |
There was a problem hiding this comment.
It would be good to clarify that this is the UUID either by renaming the define or with comments.
Also, why is the format different for data4 than the other data{1..3}.
There was a problem hiding this comment.
uint32_t data1;
uint16_t data2;
uint16_t data3;
uint8_t data4[8];
data4 is of type an array of 8 unsigned 8-bit integers.
| @@ -949,6 +949,7 @@ CHIP_ERROR BLEManagerImpl::EncodeAdditionalDataTlv() | |||
|
|
|||
| err = AdditionalDataPayloadGenerator().generateAdditionalDataPayload(additionalDataPayloadParams, c3AdditionalDataBufferHandle, | |||
| additionalDataFields); | |||
| SuccessOrExit(err); | |||
There was a problem hiding this comment.
why are we adding this here? we are already at the exit
Suggested change
| SuccessOrExit(err); |
There was a problem hiding this comment.
If this is not added, getting an error "error: label 'exit' defined but not used" , if the above code is not enabled. Like
#if CHIP_ENABLE_ROTATING_DEVICE_ID && defined(CHIP_DEVICE_CONFIG_ROTATING_DEVICE_ID_UNIQUE_ID) uint8_t rotatingDeviceIdUniqueId[ConfigurationManager::kRotatingDeviceIDUniqueIDLength] = {}; MutableByteSpan rotatingDeviceIdUniqueIdSpan(rotatingDeviceIdUniqueId); err = DeviceLayer::GetDeviceInstanceInfoProvider()->GetRotatingDeviceIdUniqueId(rotatingDeviceIdUniqueIdSpan); SuccessOrExit(err);
There was a problem hiding this comment.
I'd recommend changing the function to remove the exit/label approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 917 BleManager does not support the C3 read request which is necessary to support the additional data advertising feature.
Added C3 characteristic to the matter service.
Testing
Enabled chip_enable_additional_data_advertising while building application and verified C3 characteristic has been added after connecting to the device and able to read C3 request by enable/disable READ .