Stop advertising IPv4 addresses when IPv4 and IPv6 ports do not match. #38057
+68
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our advertising backends only support advertising one port. In cases when the IPv4 and IPv6 ports do not match, advertising the IPv6 port along with IPv4 addresses does not make sense: that port does not correspond to the Matter stack on those addresses. The fix is to only allow advertising IPv4 addresses when the port we are using for IPv6 matches the port we are using for IPv4.
|
PR #38057: Size comparison from 22a979c to f595119 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Mar 19, 2025
jmartinez-silabs
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our advertising backends only support advertising one port. In cases when the IPv4 and IPv6 ports do not match, advertising the IPv6 port along with IPv4 addresses does not make sense: that port does not correspond to the Matter stack on those addresses.
The fix is to only allow advertising IPv4 addresses when the port we are using for IPv6 matches the port we are using for IPv4.
Testing
Manually tested that starting chip-all-clusters-app normally advertises both IPv4 and IPv6 addresses, as does starting it with a fixed nonzero port, but starting it with
--secured-device-port 0only advertises the IPv6 addresses.