[CP][1.4] Fix MRP baseTimeout calculation for LIT (#37696) #38062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix MRP baseTimeout calculation when it is possible the other end fall asleep * use min(SAI, SII) for mrp timeout when clock runs into idle * Restyled by clang-format * update mrp calculation -- Use 15 seconds to determine whether device is in LIT mode, then if yes, set the timeout base as SAI if GetRemoteMRPConfig().mIdleRetransTimeout.count() > sitIcdSlowPollMaximum.count() * Address comments * address comments * Restyled by whitespace * address comments * Restyled by whitespace * Restyled by clang-format * Update src/transport/UnauthenticatedSessionTable.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/transport/Session.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/protocols/secure_channel/CASESession.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/transport/SecureSession.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/protocols/secure_channel/CASESession.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/ReadClient.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/messaging/ReliableMessageProtocolConfig.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/messaging/ReliableMessageProtocolConfig.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * address comments * address comments * update true isFirstMessageOnExchange for all ComputeRoundTripTimeout caller * Restyled by whitespace * Restyled by clang-format * fix compilation error * address comments * cleanup * add parameter isFirstMessageOnExchange in GetMessageReceiptTimeout * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
andy31415
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP #37696 to 1.4 branch
Testing
local run