Add Matter*PluginServerShutdownCallback #38075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38075: Size comparison from cbf664f to aec7ef8 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
@jadhavrohit924 could we add some usage examples as well or describe in the summary how this was planned to be used and the current status? As it stands, this would seems to be just "generated code that is unused". |
@andy31415 I have filed an issue #38092 to list the action items which would go in sequence. |
jadhavrohit924
force-pushed
the
add/plugin_shutdown
branch
from
aec7ef8 to
b308f9b
Compare
|
PR #38075: Size comparison from 2c7bc31 to b308f9b Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jadhavrohit924
force-pushed
the
add/plugin_shutdown
branch
from
b308f9b to
6b542b7
Compare
|
PR #38075: Size comparison from 7d04796 to 6b542b7 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38075: Size comparison from 7d04796 to 07f4d57 Full report (8 builds for esp32, nrfconnect, stm32, tizen)
|
|
PR #38075: Size comparison from 7d04796 to 52c4c78 Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jadhavrohit924
force-pushed
the
add/plugin_shutdown
branch
from
52c4c78 to
9615093
Compare
|
PR #38075: Size comparison from 79b53e9 to 9615093 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
shubhamdp
reviewed
Mar 28, 2025
src/app/clusters/general-commissioning-server/general-commissioning-server.cpp
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Mar 28, 2025
shubhamdp
approved these changes
Apr 1, 2025
hasty
pushed a commit
to hasty/connectedhomeip
that referenced
this pull request
Apr 2, 2025
* Add Matter*PluginServerShutdownCallback * Add definition of PluginServerShutdownCallback for every cluster * Fix CI * Address review comments * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
soares-sergio
pushed a commit
to soares-sergio/connectedhomeip
that referenced
this pull request
Apr 8, 2025
* Add Matter*PluginServerShutdownCallback * Add definition of PluginServerShutdownCallback for every cluster * Fix CI * Address review comments * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
sayondeep
pushed a commit
to sayondeep/connectedhomeip
that referenced
this pull request
Apr 10, 2025
* Add Matter*PluginServerShutdownCallback * Add definition of PluginServerShutdownCallback for every cluster * Fix CI * Address review comments * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Testing
test_generators.py