-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-FAN-2.3: Enhanced attribute value testing #38110
Open
raul-marquez-csa
wants to merge
13
commits into
project-chip:master
Choose a base branch
from
raul-marquez-csa:TC-FAN-2.3-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TC-FAN-2.3: Enhanced attribute value testing #38110
raul-marquez-csa
wants to merge
13
commits into
project-chip:master
from
raul-marquez-csa:TC-FAN-2.3-update
+138
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #38110: Size comparison from 7d04796 to db7b8b3 Full report (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #38110: Size comparison from 7d04796 to 5a30424 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rbultman
reviewed
Mar 26, 2025
Co-authored-by: Rob Bultman <rob.Bultman@gmail.com>
rbultman
approved these changes
Mar 27, 2025
cecille
reviewed
Apr 1, 2025
PR #38110: Size comparison from 2a9cb23 to 7fa1916 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
…ctedhomeip into TC-FAN-2.3-update
PR #38110: Size comparison from 2a9cb23 to 56fecf0 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #38110: Size comparison from 2a9cb23 to e2153fe Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Addresses TC-FAN-2.3 from issue
[TC-FAN] Fan tests do not sufficiently test attribute interactions #4788
- Tests should ensure the current values are in the supported values, and the supported values are in the spec, not just that this is a bitmap
Ported to Python
Enhancement testing update
Adds
RockBitmap
value constraints toRockSupport
andRockSetting
attributesChecks that
RockSetting
is conformant withRockSupport
Fan Control spec
Corresponding test plan PR - Preview