Closure device type updates as per latest specification #38122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38122: Size comparison from 3e9b41b to e2be4d1 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38122: Size comparison from 3e9b41b to c6f4c0f Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| <include cluster="Groups" client="false" server="false" clientLocked="true" serverLocked="false"></include> | ||
| <include cluster="Identify" client="false" server="true" clientLocked="true" serverLocked="true"></include> | ||
| <include cluster="Scenes Management" client="false" server="false" clientLocked="true" serverLocked="false"></include> | ||
| <include cluster="Binding" client="false" server="true" clientLocked="true" serverLocked="true"></include> |
There was a problem hiding this comment.
What happened to Descriptor?
There was a problem hiding this comment.
this part of the code is generated by alchemy. will check with them why the Descriptor is missing.
|
PR #38122: Size comparison from 8d9a031 to 0110b84 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38122: Size comparison from d38ee41 to 9809442 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| <include cluster="Groups" client="false" server="false" clientLocked="true" serverLocked="false"></include> | ||
| <include cluster="Identify" client="false" server="true" clientLocked="true" serverLocked="true"></include> | ||
| <include cluster="Scenes Management" client="false" server="false" clientLocked="true" serverLocked="false"></include> | ||
| <include cluster="Binding" client="false" server="true" clientLocked="true" serverLocked="true"></include> |
There was a problem hiding this comment.
I don't see binding in the device type spec. Why are we adding it here?
There was a problem hiding this comment.
this part of the code is generated by alchemy. will check with them why the Binding is added here.
There was a problem hiding this comment.
If it is being added here because of the base device type, why isn't it being added to the clusre panal that is also a simple class device type?
sabollim-silabs
force-pushed
the
closure_device_type_update_latest_spec
branch
from
9809442 to
2df237e
Compare
|
PR #38122: Size comparison from c7d1a48 to 2df237e Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated the XML form spec using alchemy.
Generated Zap code.
Testing
Built the code after the new device type changes.