Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readclient comment for SendAutoResubscribeRequest #38125

Merged

Conversation

yunhanw-google
Copy link
Contributor

Remove invalid/obsolete mResubscribePolicy mention for ReadClient::SendAutoResubscribeRequest

Testing

compilation

Copy link

PR #38125: Size comparison from 794cc19 to 6953158

Full report (3 builds for cc32xx, stm32)
platform target config section 794cc19 6953158 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 541966 541966 0 0.0
RAM 205152 205152 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576066 576066 0 0.0
RAM 205400 205400 0 0.0
stm32 light STM32WB5MM-DK FLASH 461160 461160 0 0.0
RAM 141496 141496 0 0.0

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@yunhanw-google yunhanw-google enabled auto-merge (squash) April 1, 2025 14:53
@yunhanw-google yunhanw-google merged commit 5abc244 into project-chip:master Apr 1, 2025
72 checks passed
hasty pushed a commit to hasty/connectedhomeip that referenced this pull request Apr 2, 2025
…8125)

* fix readclient comment for SendAutoResubscribeRequest

* Update src/app/ReadClient.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

---------

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants