Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emberAf*ClusterShutdownCallback. #38130

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Add emberAf*ClusterShutdownCallback. #38130

merged 2 commits into from
Mar 27, 2025

Conversation

jadhavrohit924
Copy link
Contributor

Problem

Changes

  • Add emberAf*ClusterShutdownCallback to the jinja and Zapt templates.
  • Changed file name ClusterInitCallbackSource.jinja --> ClusterCallbacksSource.jinja and output file cluster-init-callback.cpp --> cluster-callbacks.cpp.

Testing

  • Regerated test output by running test_generator script.
  • Zap regenerated.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2025 •
edited
Loading

PR #38130: Size comparison from 794cc19 to eb951cd

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 794cc19 eb951cd change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098468 1098468 0 0.0
RAM 94866 94866 0 0.0
bl702 lighting-app bl702+eth FLASH 653398 653398 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830654 830654 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1063158 1063158 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 893960 893960 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 976836 976836 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818604 818604 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827516 827516 0 0.0
RAM 125392 125392 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774360 774360 0 0.0
RAM 113764 113764 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 758644 758644 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 541966 541966 0 0.0
RAM 205152 205152 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576066 576066 0 0.0
RAM 205400 205400 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660173 660173 0 0.0
RAM 75436 75436 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680033 680033 0 0.0
RAM 78076 78076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680033 680033 0 0.0
RAM 78076 78076 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 636957 636957 0 0.0
RAM 70504 70504 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620469 620469 0 0.0
RAM 71676 71676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640105 640105 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640105 640105 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 639925 639925 0 0.0
RAM 74684 74684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659641 659641 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659641 659641 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616265 616265 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636125 636125 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636125 636125 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 941128 941128 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 735200 735200 0 0.0
RAM 234856 234856 0 0.0
window-app BRD4187C FLASH 1033536 1033528 -8 -0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 103384 103384 0 0.0
FLASH 1785438 1785438 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121964 121964 0 0.0
FLASH 1751914 1751914 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2659589 2659589 0 0.0
RAM 112304 112304 0 0.0
all-clusters-app debug unknown 5584 5584 0 0.0
FLASH 6124512 6124512 0 0.0
RAM 517584 517584 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5317520 5317520 0 0.0
RAM 222616 222616 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4631416 4631416 0 0.0
RAM 201000 201000 0 0.0
camera-app debug unknown 5456 5456 0 0.0
FLASH 4693950 4693950 0 0.0
RAM 196448 196448 0 0.0
camera-controller debug unknown 5776 5776 0 0.0
FLASH 11346267 11346267 0 0.0
RAM 597408 597408 0 0.0
chip-tool debug unknown 6112 6112 0 0.0
FLASH 13366455 13366455 0 0.0
RAM 606048 606048 0 0.0
chip-tool-ipv6only arm64 unknown 22120 22120 0 0.0
FLASH 11552024 11552024 0 0.0
RAM 658728 658728 0 0.0
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 11637485 11637485 0 0.0
RAM 605832 605832 0 0.0
fabric-bridge-app debug unknown 4720 4720 0 0.0
FLASH 4462368 4462368 0 0.0
RAM 188200 188200 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5579573 5579573 0 0.0
RAM 472064 472064 0 0.0
lighting-app debug+rpc+ui unknown 6192 6192 0 0.0
FLASH 5526017 5526017 0 0.0
RAM 205200 205200 0 0.0
lock-app debug unknown 5424 5424 0 0.0
FLASH 4698160 4698160 0 0.0
RAM 192360 192360 0 0.0
ota-provider-app debug unknown 4760 4760 0 0.0
FLASH 4320366 4320366 0 0.0
RAM 181016 181016 0 0.0
ota-requestor-app debug unknown 4712 4712 0 0.0
FLASH 4450722 4450722 0 0.0
RAM 185504 185504 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 2958092 2958092 0 0.0
RAM 145616 145616 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4147192 4147192 0 0.0
RAM 229848 229848 0 0.0
tv-app debug unknown 5752 5752 0 0.0
FLASH 5918389 5918389 0 0.0
RAM 595496 595496 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11539197 11539197 0 0.0
RAM 721840 721840 0 0.0
nxp contact k32w0+release FLASH 588608 588608 0 0.0
RAM 71004 71004 0 0.0
mcxw71+release FLASH 607144 607144 0 0.0
RAM 63280 63280 0 0.0
light k32w0+release FLASH 614420 614420 0 0.0
RAM 70292 70292 0 0.0
k32w1+release FLASH 691440 691440 0 0.0
RAM 72128 72128 0 0.0
lock mcxw71+release FLASH 756896 756896 0 0.0
RAM 67692 67692 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661708 1661708 0 0.0
RAM 212336 212336 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1565692 1565692 0 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442596 1442596 0 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471492 1471492 0 0.0
RAM 224984 224984 0 0.0
qpg lighting-app qpg6105+debug FLASH 665196 665196 0 0.0
RAM 105180 105180 0 0.0
lock-app qpg6105+debug FLASH 623664 623664 0 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 461160 461160 0 0.0
RAM 141496 141496 0 0.0
telink bridge-app tl7218x FLASH 665952 665952 0 0.0
RAM 90712 90712 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623544 623544 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 762730 762730 0 0.0
RAM 40436 40436 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 755838 755838 0 0.0
RAM 97548 97548 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 682902 682902 0 0.0
RAM 52200 52200 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711460 711460 0 0.0
RAM 73416 73416 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 704010 704010 0 0.0
RAM 37680 37680 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603470 603470 0 0.0
RAM 138648 138648 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 790904 790904 0 0.0
RAM 96404 96404 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1784000 1784000 0 0.0
RAM 94280 94280 0 0.0
chip-tool-ubsan arm unknown 11560 11560 0 0.0
FLASH 19107902 19107902 0 0.0
RAM 8356268 8356268 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2025 •
edited
Loading

PR #38130: Size comparison from 794cc19 to 4093e0d

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 794cc19 4093e0d change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098468 1098468 0 0.0
RAM 94866 94866 0 0.0
bl702 lighting-app bl702+eth FLASH 653398 653398 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830654 830654 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1063158 1063158 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 893960 893960 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 976836 976836 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818604 818604 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827516 827516 0 0.0
RAM 125392 125392 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774360 774360 0 0.0
RAM 113764 113764 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 758644 758644 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 541966 541966 0 0.0
RAM 205152 205152 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576066 576066 0 0.0
RAM 205400 205400 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660173 660173 0 0.0
RAM 75436 75436 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680033 680033 0 0.0
RAM 78076 78076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680033 680033 0 0.0
RAM 78076 78076 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 636957 636957 0 0.0
RAM 70504 70504 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620469 620469 0 0.0
RAM 71676 71676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640105 640105 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640105 640105 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 639925 639925 0 0.0
RAM 74684 74684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659641 659641 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659641 659641 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616265 616265 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636125 636125 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636125 636125 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 941128 941128 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 735200 735200 0 0.0
RAM 234856 234856 0 0.0
window-app BRD4187C FLASH 1033536 1033528 -8 -0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 103384 103384 0 0.0
FLASH 1785438 1785454 16 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121964 121964 0 0.0
FLASH 1751914 1751930 16 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2659589 2659589 0 0.0
RAM 112304 112304 0 0.0
all-clusters-app debug unknown 5584 5584 0 0.0
FLASH 6124512 6124544 32 0.0
RAM 517584 517584 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5317520 5317520 0 0.0
RAM 222616 222616 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4631416 4631416 0 0.0
RAM 201000 201000 0 0.0
camera-app debug unknown 5456 5456 0 0.0
FLASH 4693950 4693950 0 0.0
RAM 196448 196448 0 0.0
camera-controller debug unknown 5776 5776 0 0.0
FLASH 11346267 11346267 0 0.0
RAM 597408 597408 0 0.0
chip-tool debug unknown 6112 6112 0 0.0
FLASH 13366455 13366455 0 0.0
RAM 606048 606048 0 0.0
chip-tool-ipv6only arm64 unknown 22120 22120 0 0.0
FLASH 11552024 11552024 0 0.0
RAM 658728 658728 0 0.0
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 11637485 11637485 0 0.0
RAM 605832 605832 0 0.0
fabric-bridge-app debug unknown 4720 4720 0 0.0
FLASH 4462368 4462368 0 0.0
RAM 188200 188200 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5579573 5579573 0 0.0
RAM 472064 472064 0 0.0
lighting-app debug+rpc+ui unknown 6192 6192 0 0.0
FLASH 5526017 5526017 0 0.0
RAM 205200 205200 0 0.0
lock-app debug unknown 5424 5424 0 0.0
FLASH 4698160 4698160 0 0.0
RAM 192360 192360 0 0.0
ota-provider-app debug unknown 4760 4760 0 0.0
FLASH 4320366 4320366 0 0.0
RAM 181016 181016 0 0.0
ota-requestor-app debug unknown 4712 4712 0 0.0
FLASH 4450722 4450722 0 0.0
RAM 185504 185504 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 2958092 2958124 32 0.0
RAM 145616 145616 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4147192 4147192 0 0.0
RAM 229848 229848 0 0.0
tv-app debug unknown 5752 5752 0 0.0
FLASH 5918389 5918389 0 0.0
RAM 595496 595496 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11539197 11539197 0 0.0
RAM 721840 721840 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916308 916320 12 0.0
RAM 167447 167447 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 908976 908992 16 0.0
RAM 145691 145691 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852776 852776 0 0.0
RAM 141227 141227 0 0.0
nxp contact k32w0+release FLASH 588608 588608 0 0.0
RAM 71004 71004 0 0.0
mcxw71+release FLASH 607144 607144 0 0.0
RAM 63280 63280 0 0.0
light k32w0+release FLASH 614420 614420 0 0.0
RAM 70292 70292 0 0.0
k32w1+release FLASH 691440 691440 0 0.0
RAM 72128 72128 0 0.0
lock mcxw71+release FLASH 756896 756896 0 0.0
RAM 67692 67692 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661708 1661724 16 0.0
RAM 212336 212336 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1565692 1565692 0 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442596 1442596 0 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471492 1471492 0 0.0
RAM 224984 224984 0 0.0
qpg lighting-app qpg6105+debug FLASH 665196 665196 0 0.0
RAM 105180 105180 0 0.0
lock-app qpg6105+debug FLASH 623664 623664 0 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 461160 461160 0 0.0
RAM 141496 141496 0 0.0
telink bridge-app tl7218x FLASH 665952 665952 0 0.0
RAM 90712 90712 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623544 623544 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 762730 762730 0 0.0
RAM 40436 40436 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 755838 755838 0 0.0
RAM 97548 97548 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 682902 682902 0 0.0
RAM 52200 52200 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711460 711460 0 0.0
RAM 73416 73416 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 704010 704010 0 0.0
RAM 37680 37680 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603470 603470 0 0.0
RAM 138648 138648 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 790904 790904 0 0.0
RAM 96404 96404 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1784000 1784016 16 0.0
RAM 94280 94280 0 0.0
chip-tool-ubsan arm unknown 11560 11560 0 0.0
FLASH 19107902 19107902 0 0.0
RAM 8356268 8356268 0 0.0

@mergify mergify bot merged commit 5f2ba43 into project-chip:master Mar 27, 2025
71 checks passed
@jadhavrohit924 jadhavrohit924 mentioned this pull request Mar 27, 2025
Merged
juandediosg pushed a commit to juandediosg/connectedhomeip that referenced this pull request Mar 28, 2025
@jadhavrohit924 @juandediosg
Add emberAf*ClusterShutdownCallback. (project-chip#38130)
60f8b91 
* Add emberAf*ClusterShutdownCallback.

* Address review comment.
juandediosg pushed a commit to juandediosg/connectedhomeip that referenced this pull request Mar 28, 2025
@jadhavrohit924 @juandediosg
Add emberAf*ClusterShutdownCallback. (project-chip#38130)
2f6f728 
* Add emberAf*ClusterShutdownCallback.

* Address review comment.
@jadhavrohit924 jadhavrohit924 deleted the add/cluster_shutdown branch April 2, 2025 08:57
hasty pushed a commit to hasty/connectedhomeip that referenced this pull request Apr 2, 2025
@jadhavrohit924 @hasty
Add emberAf*ClusterShutdownCallback. (project-chip#38130)
6f1f940 
* Add emberAf*ClusterShutdownCallback.

* Address review comment.
soares-sergio pushed a commit to soares-sergio/connectedhomeip that referenced this pull request Apr 8, 2025
@jadhavrohit924 @soares-sergio
Add emberAf*ClusterShutdownCallback. (project-chip#38130)
f612b4e 
* Add emberAf*ClusterShutdownCallback.

* Address review comment.
sayondeep pushed a commit to sayondeep/connectedhomeip that referenced this pull request Apr 10, 2025
@jadhavrohit924
Add emberAf*ClusterShutdownCallback. (project-chip#38130)
8dcf7b6 
* Add emberAf*ClusterShutdownCallback.

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@shubhamdp shubhamdp shubhamdp approved these changes

Assignees
No one assigned
Labels
app review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jadhavrohit924 @andy31415 @shubhamdp