build_python.sh: Allow to install multiple python packages with --extra_packages #38131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra_packages Signed-off-by: Maciej Grela <m.grela@samsung.com>
andy31415
approved these changes
Mar 26, 2025
andy31415
reviewed
Mar 26, 2025
…e defined Currently restyle's shellharden does not allow us to use shell word splitting to append multiple package names to WHEEL. In order to fix this and keep restyled happy the --extra_packages can now be specified multiple times collecting the extra packages into an array. A shorthand was also added to make this less verbose. Signed-off-by: Maciej Grela <m.grela@samsung.com>
|
PR #38131: Size comparison from 85e9d5f to 12b05b9 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Mar 31, 2025
hasty
pushed a commit
to hasty/connectedhomeip
that referenced
this pull request
Apr 2, 2025
…ra_packages (project-chip#38131) * build_python.sh: Allow to install multiple python packages with --extra_packages Signed-off-by: Maciej Grela <m.grela@samsung.com> * build_packages.sh: Improve the way multiple extra PyPI packages can be defined Currently restyle's shellharden does not allow us to use shell word splitting to append multiple package names to WHEEL. In order to fix this and keep restyled happy the --extra_packages can now be specified multiple times collecting the extra packages into an array. A shorthand was also added to make this less verbose. Signed-off-by: Maciej Grela <m.grela@samsung.com> --------- Signed-off-by: Maciej Grela <m.grela@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Testing
Tested by running the above command on master and confirming that the venv builds with the requested packages and works (
chipcan be imported).