[TC-CHANNEL-5.9] Add YAML Script for ChangeChannel Command Verification #38132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38132: Size comparison from 47550d5 to f50e586 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
chrisdecenzo
approved these changes
Mar 26, 2025
| arguments: | ||
| values: | ||
| - name: "Match" | ||
| value: "PBS" # Example, choose from the available ChannelList |
There was a problem hiding this comment.
Can you help me understand how this will work? Shouldn't the script actually read a value from the channel list returned in step 1?
There was a problem hiding this comment.
+1 - the test description is "with a channel from the list in step 1" ... this is just a hardcoded value.
Please update the test step or write it in python if yaml is too restrictive to have this support.
andy31415
requested changes
Mar 26, 2025
andy31415
reviewed
Mar 26, 2025
|
|
||
| - label: "Step 2a: Verify that the channel has changed on the device" | ||
| cluster: "LogCommands" | ||
| command: "UserPrompt" |
There was a problem hiding this comment.
we generally disallow manual tests in the harness. This does seem optional though as we check current channel, however I wonder if we should adjust the test plan instead:
- step 2 should probably pick a "different channel than the current one"
- step 3 can verify that channel change was successful ... maybe reading the new channel name is sufficient
If we can run tests without human intervention, that would be better (and in this case if we can trust CurrentChannel that would be great).
|
PR #38132: Size comparison from 1739c88 to 06a22a5 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38132: Size comparison from 8d9a031 to de138ca Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Summary
This PR adds a YAML test script to validate the ChangeChannel command on the server side.
Changes
Test_TC_CHANNEL_5_9.yamlto verify ChangeChannel functionality.ChannelListandCurrentChannelattributes.Related Issue
Fixes #2317
Additional details
Sha: 2154a06).