Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build: avoid implicit deletion of ChipDeviceEvent default constructor #38166

Closed
wants to merge 1 commit into from
Closed

Fix build: avoid implicit deletion of ChipDeviceEvent default constructor #38166

wants to merge 1 commit into from

Conversation

j0tunn
Copy link
Contributor

@j0tunn j0tunn commented Mar 28, 2025

Avoid build errors with clang:

src/protocols/secure_channel/PairingSession.cpp:84:38: error: call to implicitly-deleted default constructor of 'DeviceLayer::ChipDeviceEvent'
   84 |         DeviceLayer::ChipDeviceEvent event;
      |                                      ^
src/include/platform/CHIPDeviceEvent.h:403:33: note: default constructor of 'ChipDeviceEvent' is implicitly deleted because field 'Platform' has a deleted default constructor
  403 |         ChipDevicePlatformEvent Platform;
      |                                 ^
src/platform/Linux/CHIPDevicePlatformEvent.h:85:11: note: default constructor of 'ChipDevicePlatformEvent' is implicitly deleted because variant field 'BLECentralConnectFailed' has a non-trivial default constructor
   85 |         } BLECentralConnectFailed;
      |           ^

Testing

Manual build

@j0tunn j0tunn closed this Mar 28, 2025
@j0tunn j0tunn deleted the fix/device-event.build.fix branch March 28, 2025 16:37
@j0tunn
Copy link
Contributor Author

j0tunn commented Mar 28, 2025

Already fixed in #36768

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2025 •
edited
Loading

PR #38166: Size comparison from 97ffa50 to 6170a1f

Full report (57 builds for cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 97ffa50 6170a1f change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818604 818604 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827516 827516 0 0.0
RAM 125392 125392 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774360 774360 0 0.0
RAM 113764 113764 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 758644 758644 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 541966 541966 0 0.0
RAM 205152 205152 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576066 576066 0 0.0
RAM 205400 205400 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660173 660173 0 0.0
RAM 75436 75436 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680033 680033 0 0.0
RAM 78076 78076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680033 680033 0 0.0
RAM 78076 78076 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 636957 636957 0 0.0
RAM 70504 70504 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620469 620469 0 0.0
RAM 71676 71676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640105 640105 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640105 640105 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 639925 639925 0 0.0
RAM 74684 74684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659641 659641 0 0.0
RAM 77228 77228 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659641 659641 0 0.0
RAM 77228 77228 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616265 616265 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636125 636125 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636125 636125 0 0.0
RAM 71412 71412 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2659589 2659589 0 0.0
RAM 112304 112304 0 0.0
all-clusters-app debug unknown 5584 5584 0 0.0
FLASH 6130794 6130794 0 0.0
RAM 517648 517648 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5317520 5317520 0 0.0
RAM 222616 222616 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4631416 4631416 0 0.0
RAM 201000 201000 0 0.0
camera-app debug unknown 5456 5456 0 0.0
FLASH 4693950 4693950 0 0.0
RAM 196448 196448 0 0.0
camera-controller debug unknown 5776 5776 0 0.0
FLASH 11346267 11346267 0 0.0
RAM 597408 597408 0 0.0
chip-tool debug unknown 6112 6112 0 0.0
FLASH 13366455 13366455 0 0.0
RAM 606048 606048 0 0.0
chip-tool-ipv6only arm64 unknown 22120 22120 0 0.0
FLASH 11552024 11551992 -32 -0.0
RAM 658728 658728 0 0.0
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 11637485 11637485 0 0.0
RAM 605832 605832 0 0.0
fabric-bridge-app debug unknown 4720 4720 0 0.0
FLASH 4462368 4462368 0 0.0
RAM 188200 188200 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5579573 5579573 0 0.0
RAM 472064 472064 0 0.0
lighting-app debug+rpc+ui unknown 6192 6192 0 0.0
FLASH 5526017 5526017 0 0.0
RAM 205200 205200 0 0.0
lock-app debug unknown 5424 5424 0 0.0
FLASH 4698160 4698160 0 0.0
RAM 192360 192360 0 0.0
ota-provider-app debug unknown 4760 4760 0 0.0
FLASH 4320366 4320366 0 0.0
RAM 181016 181016 0 0.0
ota-requestor-app debug unknown 4712 4712 0 0.0
FLASH 4450722 4450722 0 0.0
RAM 185504 185504 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 2958124 2958124 0 0.0
RAM 145616 145616 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4147192 4147160 -32 -0.0
RAM 229848 229848 0 0.0
tv-app debug unknown 5752 5752 0 0.0
FLASH 5918389 5918389 0 0.0
RAM 595496 595496 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11539197 11539197 0 0.0
RAM 721840 721840 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916320 916408 88 0.0
RAM 167447 167447 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 908992 909092 100 0.0
RAM 145691 145691 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852776 852872 96 0.0
RAM 141227 141227 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661724 1661772 48 0.0
RAM 212336 212336 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1565692 1565724 32 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442596 1442644 48 0.0
RAM 197320 197320 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471492 1471540 48 0.0
RAM 224984 224984 0 0.0
qpg lighting-app qpg6105+debug FLASH 665196 665220 24 0.0
RAM 105180 105180 0 0.0
lock-app qpg6105+debug FLASH 623664 623672 8 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 461160 461184 24 0.0
RAM 141496 141496 0 0.0
telink bridge-app tl7218x FLASH 689144 689238 94 0.0
RAM 101860 101860 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 777182 777280 98 0.0
RAM 50128 50128 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 767444 767542 98 0.0
RAM 40428 40428 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 783818 756000 -27818 -3.5
RAM 109316 97548 -11768 -10.8
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 705116 683102 -22014 -3.1
RAM 62628 51596 -11032 -17.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 741298 711552 -29746 -4.0
RAM 85816 73416 -12400 -14.4
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 709000 709098 98 0.0
RAM 37052 37052 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603038 603140 102 0.0
RAM 148712 148712 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 818424 790994 -27430 -3.4
RAM 107576 96404 -11172 -10.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j0tunn