Fix TC-SC-5.1 Step 9b Failure for Devices Without Groups Cluster Support #38171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38171: Size comparison from 97ffa50 to d045200 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Now, the fabricIndex is read dynamically instead of being hardcoded, so there won't be any issues if a new fabric value is used—the test will handle it automatically. |
|
PR #38171: Size comparison from 97ffa50 to af41aed Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Mar 31, 2025
Comment on lines
64
to
71
| FabricIndex: 1, | ||
| FabricIndex: CurrentFabricIndexValue, |
There was a problem hiding this comment.
Why this change? Value is ignored on write anyway. If this should be changed at all, should be changed to 0.
There was a problem hiding this comment.
You're right. I’ve left it at 0 on writesAttribute. Thanks for the clarification!
| value: | ||
| [ | ||
| { | ||
| FabricIndex: CurrentFabricIndexValue, |
There was a problem hiding this comment.
Again, this value is ignored on write. Should be 0 or something, or no changes.
There was a problem hiding this comment.
Got it. I’ve set this to 0 on this one as well. Thanks for the review!
| value: | ||
| [ | ||
| { | ||
| FabricIndex: CurrentFabricIndexValue, |
There was a problem hiding this comment.
In this case, it's important to keep CurrentFabricIndexValue instead of 0 since this comes from readAttribute, not writeAttribute. Otherwise, if the fabric changes for some reason, this test step could fail.
| @@ -319,7 +340,7 @@ tests: | |||
| value: | |||
| [ | |||
| { | |||
| FabricIndex: 1, | |||
| FabricIndex: CurrentFabricIndexValue, | |||
There was a problem hiding this comment.
I did the same—set this to 0. Thank you for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue project-chip/matter-test-scripts#463, where Step 9b of TC-SC-5.1 was failing when the device does not support the Groups Cluster.
Summary of Fix:
Testing
Tested on the following apps:
chip-all-clusters-app 1.0