Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TC-LCFG-2.1 #485

Open
cecille opened this issue Jan 17, 2025 · 1 comment · May be fixed by project-chip/connectedhomeip#37434
Open

TC-LCFG-2.1 #485

cecille opened this issue Jan 17, 2025 · 1 comment · May be fixed by project-chip/connectedhomeip#37434
Assignees
@r-recchia
Labels
automation good first issue Good for newcomers

Comments

@cecille
Copy link
Contributor

cecille commented Jan 17, 2025

  • consider removing the step to try writing the attribute - this is already tested by another test
  • this test should actually assess that the strings follow the required format, which the current test script does not do

This is a python candidate because of the string processing.

current test script: https://github.com/project-chip/connectedhomeip/blob/master/src/app/tests/suites/certification/Test_TC_LCFG_2_1.yaml
test plan: https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/Localization.adoc
@cecille cecille added automation good first issue Good for newcomers labels Jan 17, 2025
@cecille cecille added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jan 28, 2025
@r-recchia r-recchia self-assigned this Jan 30, 2025
@r-recchia r-recchia linked a pull request Feb 6, 2025 that will close this issue
Open
@r-recchia
Copy link

PR: project-chip/connectedhomeip#37434
Test Specifications PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/4953

@r-recchia r-recchia moved this from In progress to In review in Google certification and testing project Feb 7, 2025
@r-recchia r-recchia moved this from In review to Needs Google review in Google certification and testing project Feb 21, 2025
@cecille cecille moved this from Needs Google review to ReviewComments in Google certification and testing project Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-recchia r-recchia

Labels
automation good first issue Good for newcomers
Projects
Google certification and testing project
Status: ReviewComments
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate TC-LCFG-2.1 test from yaml to python r-recchia/connectedhomeip
2 participants
@cecille @r-recchia