Migrate TC-LCFG-2.1 test from yaml to python #37434

r-recchia · 2025-02-06T18:52:15Z

This PR migrates TC-LCFG-2.1 test from yaml to python. It is linked to Fixes #485.

It also includes changes in test specifications PR 4953.

Updates:

Removed step to try writing the attribute SupportedLocales and gets the outcome UNSUPPORTED_WRITE
Migrated to python

Testing

In the first terminal:

Clear commissioning data:
```
rm /tmp/chip_*
```

Build light:

./scripts/build/build_examples.py –target linux-x64-all-clusters build

Run:

./out/linux-x64-all-clusters/chip-all-clusters

In the second terminal:

Activate Python environment

Test:

python3 src/python_testing/TC_LCFG_2_1.py commissioning-method on-network --qr-code MT:-24J042C00KA0648G00 --endpoint 0

semanticdiff-com · 2025-02-06T18:52:18Z

Review changes with

Changed Files

File	Status
src/app/tests/suites/certification/Test_TC_LCFG_2_1.yaml	0% smaller
src/python_testing/TC_LCFG_2_1.py	0% smaller
src/python_testing/requirements.txt	Unsupported file format

github-actions · 2025-02-06T19:25:15Z

PR #37434: Size comparison from 35781e5 to f5785a2

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`35781e5`	f5785a22
bl602	lighting-app	bl602+mfd+littlefs+rpc	FLASH	`1094024`	`1094024`
			RAM	103314	103314
bl702	lighting-app	bl702+eth	FLASH	650542	650542
			RAM	25265	25265
		bl702+wifi	FLASH	828506	828506
			RAM	13981	13981
		bl706+mfd+rpc+littlefs	FLASH	1057066	1057066
			RAM	23861	23861
bl702l	contact-sensor-app	bl702l+mfd+littlefs	FLASH	888444	888444
			RAM	18504	18504
	lighting-app	bl702l+mfd+littlefs	FLASH	971486	971486
			RAM	16368	16368
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	838240	838240
			RAM	123480	123480
	lock-ftd	LP_EM_CC1354P10_6	FLASH	823644	823644
			RAM	125360	125360
	pump-app	LP_EM_CC1354P10_6	FLASH	770820	770820
			RAM	113820	113820
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	755088	755088
			RAM	114028	114028
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	538621	538621
			RAM	205208	205208
	lock	CC3235SF_LAUNCHXL	FLASH	572493	572493
			RAM	205360	205360
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	679585	679585
			RAM	78548	78548
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	699429	699429
			RAM	81188	81188
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	699429	699429
			RAM	81188	81188
		CYW930739M2EVB-02	unknown	2040	2040
			FLASH	656365	656365
			RAM	73616	73616
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	615945	615945
			RAM	71532	71532
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	635573	635573
			RAM	74076	74076
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	635573	635573
			RAM	74076	74076
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	635449	635449
			RAM	74540	74540
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	655157	655157
			RAM	77084	77084
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	655157	655157
			RAM	77084	77084
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040
			FLASH	611861	611861
			RAM	68628	68628
		CYW30739B2-P5-EVK-02	unknown	2040	2040
			FLASH	631721	631721
			RAM	71268	71268
		CYW30739B2-P5-EVK-03	unknown	2040	2040
			FLASH	631721	631721
			RAM	71268	71268
efr32	lock-app	BRD4187C	FLASH	936408	936408
			RAM	159872	159872
		BRD4338a	FLASH	730348	730348
			RAM	234716	234716
	window-app	BRD4187C	FLASH	`1029656`	`1029656`
			RAM	128008	128008
esp32	all-clusters-app	c3devkit	DRAM	97312	97312
			FLASH	`1577420`	`1577420`
			IRAM	83820	83820
		m5stack	DRAM	116100	116100
			FLASH	1545326	1545326
			IRAM	117039	117039
linux	air-purifier-app	debug	unknown	4760	4760
			FLASH	2709171	2709171
			RAM	132784	132784
	all-clusters-app	debug	unknown	5568	5568
			FLASH	5975584	5975584
			RAM	531600	531600
	all-clusters-minimal-app	debug	unknown	5464	5464
			FLASH	5323948	5323948
			RAM	242712	242712
	bridge-app	debug	unknown	5480	5480
			FLASH	4682560	4682560
			RAM	221448	221448
	chip-tool	debug	unknown	6120	6120
			FLASH	13099268	13099268
			RAM	596578	596578
	chip-tool-ipv6only	arm64	unknown	21816	21816
			FLASH	11162800	11162800
			RAM	648256	648256
	fabric-admin	debug	unknown	5808	5808
			FLASH	11388297	11388297
			RAM	596362	596362
	fabric-bridge-app	debug	unknown	4736	4736
			FLASH	`4507818`	`4507818`
			RAM	208632	208632
	fabric-sync	debug	unknown	4976	4976
			FLASH	5614085	5614085
			RAM	483504	483504
	lighting-app	debug+rpc+ui	unknown	6144	6144
			FLASH	`5625217`	`5625217`
			RAM	231728	231728
	lock-app	debug	unknown	5416	5416
			FLASH	4731186	4731186
			RAM	207696	207696
	ota-provider-app	debug	unknown	4776	4776
			FLASH	4360136	4360136
			RAM	201336	201336
	ota-requestor-app	debug	unknown	4728	4728
			FLASH	4497640	4497640
			RAM	205920	205920
	shell	debug	unknown	4256	4256
			FLASH	3005709	3005709
			RAM	160472	160472
	thermostat-no-ble	arm64	unknown	9512	9512
			FLASH	`4097192`	`4097192`
			RAM	246024	246024
	tv-app	debug	unknown	5744	5744
			FLASH	5952965	5952965
			RAM	606904	606904
	tv-casting-app	debug	unknown	5320	5320
			FLASH	11272797	11272797
			RAM	710864	710864
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	907432	907432
			RAM	142411	142411
		nrf7002dk_nrf5340_cpuapp	FLASH	901980	901980
			RAM	124755	124755
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	846040	846040
			RAM	141339	141339
nxp	contact	k32w0+release	FLASH	584624	584624
			RAM	70876	70876
		mcxw71+release	FLASH	599936	599936
			RAM	63096	63096
	light	k32w0+release	FLASH	610932	610932
			RAM	70268	70268
		k32w1+release	FLASH	685336	685336
			RAM	48680	48680
	lock	mcxw71+release	FLASH	748832	748832
			RAM	67492	67492
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646740	1646740
			RAM	211576	211576
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1553628	1553628
			RAM	208392	208392
	light	cy8ckit_062s2_43012	FLASH	1469356	1469356
			RAM	200368	200368
	lock	cy8ckit_062s2_43012	FLASH	1467308	1467308
			RAM	224704	224704
qpg	lighting-app	qpg6105+debug	FLASH	662216	662216
			RAM	105220	105220
	lock-app	qpg6105+debug	FLASH	619996	619996
			RAM	99664	99664
stm32	light	STM32WB5MM-DK	FLASH	482872	482872
			RAM	144688	144688
telink	bridge-app	tl7218x	FLASH	665258	665258
			RAM	90828	90828
	contact-sensor-app	tlsr9528a_retention	FLASH	622020	622020
			RAM	31500	31500
	light-app-ota-shell-factory-data	tl3218x	FLASH	770804	770804
			RAM	43568	43568
		tl7218x	FLASH	779306	779306
			RAM	98704	98704
	light-switch-app-ota-compress-lzma-factory-data	tl7218x_retention	FLASH	680618	680618
			RAM	52192	52192
	light-switch-app-ota-compress-lzma-shell-factory-data	tlsr9528a	FLASH	709172	709172
			RAM	73400	73400
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	626108	626108
			RAM	142032	142032
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	813492	813492
			RAM	99576	99576
tizen	all-clusters-app	arm	unknown	5104	5104
			FLASH	1752232	1752232
			RAM	93508	93508
	chip-tool-ubsan	arm	unknown	11396	11396
			FLASH	18696694	18696694
			RAM	8182536	8182536

src/python_testing/TC_LCFG_2_1.py

…es with has_cluster

src/python_testing/TC_LCFG_2_1.py

…han 35 bytes for an assertion of every element

cecille · 2025-03-03T17:45:29Z

src/python_testing/TC_LCFG_2_1.py

+    async def test_TC_LCFG_2_1(self):
+
+        endpoint = self.get_endpoint(default=0)
+        value_not_present_in_supported_locales = "fw-GB"


how do you know this value isn't in the supported locales?

This value is the same as in the yaml test

fw-GB is not a valid language tag defined in BCP47, it should not be present in supported locales

Migrate TC-LCFG-2.1 test from yaml to python

752043b

pullapprove bot added the review - pending label Feb 6, 2025

github-actions bot added app tests labels Feb 6, 2025

restyle changes

f79a4a0

r-recchia mentioned this pull request Feb 6, 2025

TC-LCFG-2.1 project-chip/matter-test-scripts#485

Open

r-recchia added 2 commits February 6, 2025 19:10

rename variable name

7303113

Remove file

f5785a2

tersal reviewed Feb 10, 2025

View reviewed changes

src/python_testing/TC_LCFG_2_1.py Outdated Show resolved Hide resolved

r-recchia added 2 commits February 11, 2025 13:52

Change async_test_body decorator to run_if_endpendpoif_endpoint_match…

2144d0b

…es with has_cluster

Re style

670ea97

andy31415 reviewed Feb 11, 2025

View reviewed changes

src/python_testing/TC_LCFG_2_1.py Outdated Show resolved Hide resolved

andy31415 reviewed Feb 11, 2025

View reviewed changes

src/python_testing/TC_LCFG_2_1.py Outdated Show resolved Hide resolved

Remove functions

c48efc3

cecille reviewed Feb 11, 2025

View reviewed changes

r-recchia added 3 commits February 12, 2025 14:01

Changed assertion types, remodified logs, rename variables

c77a534

restyle

8639448

Change function that asserts true if every element is less or equal t…

7569a6d

…han 35 bytes for an assertion of every element

cecille reviewed Mar 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate TC-LCFG-2.1 test from yaml to python #37434

Migrate TC-LCFG-2.1 test from yaml to python #37434

r-recchia commented Feb 6, 2025 •

edited

Loading

semanticdiff-com bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

cecille Mar 3, 2025

r-recchia Mar 5, 2025 •

edited

Loading

r-recchia Mar 5, 2025

Migrate TC-LCFG-2.1 test from yaml to python #37434

Are you sure you want to change the base?

Migrate TC-LCFG-2.1 test from yaml to python #37434

Conversation

r-recchia commented Feb 6, 2025 • edited Loading

Updates:

Testing

semanticdiff-com bot commented Feb 6, 2025 • edited Loading

github-actions bot commented Feb 6, 2025 • edited Loading

cecille Mar 3, 2025

Choose a reason for hiding this comment

r-recchia Mar 5, 2025 • edited Loading

Choose a reason for hiding this comment

r-recchia Mar 5, 2025

Choose a reason for hiding this comment

r-recchia commented Feb 6, 2025 •

edited

Loading

semanticdiff-com bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

r-recchia Mar 5, 2025 •

edited

Loading