Fix Unknown build info in CodeFlare operator log #495
Conversation
Makefile
Outdated
| go run \ | ||
| -ldflags " \ | ||
| -X 'main.OperatorVersion=$(BUILD_VERSION)' \ | ||
| -X 'main.McadVersion=$(MCAD_VERSION)' \ | ||
| -X 'main.InstaScaleVersion=$(INSTASCALE_VERSION)' \ | ||
| -X 'main.BuildDate=$(BUILD_DATE)' \ | ||
| " \ | ||
| ./main.go |
There was a problem hiding this comment.
So this will only set these values when make run is used to run the code locally. I believe the root of this issue is actually the Dockerfile. It directly calls go build rather than using the make directive specified in this file.
If you change the dockerfile to use make build https://github.com/project-codeflare/codeflare-operator/pull/495/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R164-R173 I think it will solve the issue.
config/manager/params.env
Outdated
| @@ -1 +1 @@ | |||
| codeflare-operator-controller-image=quay.io/opendatahub/codeflare-operator:v1.2.0 | |||
| codeflare-operator-controller-image=quay.io/rh-ee-obazylie/codeflare-operator:test1 | |||
There was a problem hiding this comment.
Left over testing val
oksanabaza
force-pushed
the
build-logs
branch
2 times, most recently
from
7617c0c to
7e45fd1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue link
https://issues.redhat.com/browse/RHOAIENG-118
What changes have been made
Fix Unknown build info in CodeFlare operator log
Verification steps
Checks