Skip to content

Remove drawing CalloutTooltip upon FingerHoverOver Hit #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alanpoon
Copy link
Contributor

added a delay timer on callout tooltip

@alanpoon alanpoon self-assigned this Mar 14, 2025
@alanpoon alanpoon added the waiting-on-review This issue is waiting to be reviewed label Mar 14, 2025
@alanpoon alanpoon changed the title Remove drawing CalloutTooltip upon FingerHoverIn Hit Remove drawing CalloutTooltip upon FingerHoverOver Hit Mar 14, 2025
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Is there another way to do this besides a timer? We've repeatedly found that timers aren't a good way to handle things that require a sequence of events (e.g., animations, log in steps, etc). Additionally, timers don't seem to behave consistently across platforms; for example, I can't get timers to fire accurately across 3 different Android devices (which is a Makepad-level problem that we should address separately, but still).

If there are no other ways to accomplish this, that's fine, but we should at least try a few alternatives first.

@kevinaboos kevinaboos added waiting-on-author This issue is waiting on the original author for a response blocked-on-makepad Blocked on a Makepad bug or missing Makepad feature and removed waiting-on-review This issue is waiting to be reviewed waiting-on-author This issue is waiting on the original author for a response labels Mar 19, 2025
@kevinaboos
Copy link
Member

Marking as blocked-on-makepad because Rik is drafting an example of how to immediately reposition just-drawn widgets

see: https://discord.com/channels/675030666576134155/855002110256742430/1351742021294882930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-on-makepad Blocked on a Makepad bug or missing Makepad feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants