Feat: added a new parameter -js to javascript injection in headless #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httpx v1.6.9 release prep
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.31.0. - [Commits](golang/crypto@v0.27.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…abot/go_modules/golang.org/x/crypto-0.31.0
michael2to3
changed the title
|
@michael2to3 thank you for the PR, can you please create issue and link back to this PR with information including use case and example. |
|
Well done: #2067 |
dwisiswant0
requested changes
Jan 15, 2025
There was a problem hiding this comment.
This should execute if the flag isn't an empty string, regardless of whether the user uses the -ss/-screenshot flag. There should also be a dedicated method for this, separate from the ScreenshotWithBody method (something like EvalJavaScript, etc.). It should run after the DOM Content Loaded page lifecycle event.
| @@ -390,6 +392,7 @@ func ParseOptions() *Options { | |||
| flagSet.BoolVarP(&options.NoHeadlessBody, "exclude-headless-body", "ehb", false, "enable excluding headless header from json output"), | |||
| flagSet.DurationVarP(&options.ScreenshotTimeout, "screenshot-timeout", "st", 10*time.Second, "set timeout for screenshot in seconds"), | |||
| flagSet.DurationVarP(&options.ScreenshotIdle, "screenshot-idle", "sid", 1*time.Second, "set idle time before taking screenshot in seconds"), | |||
| flagSet.StringSliceVarP(&options.JavascriptInject, "javascript-inject", "js", nil, "set javascript to inject", goflags.StringSliceOptions), | |||
There was a problem hiding this comment.
Suggested change
| flagSet.StringSliceVarP(&options.JavascriptInject, "javascript-inject", "js", nil, "set javascript to inject", goflags.StringSliceOptions), | |
| flagSet.StringSliceVarP(&options.JavascriptInject, "javascript-code", "jsc", nil, "execute JavaScript code after DOM content loaded", goflags.StringSliceOptions), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
-jsand--javascript-injectoptions execute code in the session browser without a head to change, for example, "local storage` or any other scriptsExample:
index.html
t.js tt.js ttt.js
If something needs improvement, then write, I am open to change